Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v14.8.0 #49375

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Upgrade EUI to v14.8.0 #49375

merged 2 commits into from
Oct 29, 2019

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Oct 25, 2019

Summary

Upgrades EUI from 14.7.0 to 14.8.0, this is a release of EuiDataGrid and some related bug fixes and enhancements to other components.

The unit test changes are a result of an accessibility change which removed a selector used by a couple tests. I've updated the selector to an equally bad choice (eh, maybe a little better), but EUI's table pagination doesn't give much to work with right now.

One change introduced the typo'd aira-modal attribute, there is a subsequent fix for this which we'll make sure follows this PR into the 7.x branch.

14.8.0

  • EuiButtonGroup and EuiButtonToggle now accept ReactNode for their label prop instead of string (#2392)
  • Added useRenderToText to inner_text service suite to render ReactNodes into label text (#2392)
  • Added icons tableDensityExpanded, tableDensityCompact, tableDensityNormal to EuiIcon (#2230)
  • Added !important to the animation of EuiFocusRing animation to make sure it is always used (#2230)
  • Added expandMini icon to EuiIcon (#2207)
  • Changed EuiPopover to use role="dialog" for better screen-reader announcements (#2207)
  • Added function callback onTrapDeactivation to EuiPopover for when a focus trap is deactivated (#2366)
  • Added logic for rendering of focus around EuiPopover to counteract a race condition (#2366)
  • Added EuiDataGrid (#2165)

Bug fixes

  • Corrected lockProps passdown in EuiFocusTrap, specifically to allows style to be passed down. (#2230)
  • Changed children property on I18nTokensShape type from a single ReactChild to now accept an array (#2230)
  • Adjusted the color of $euiColorHighlight in dark mode (#2176)
  • Changed EuiPopoverFooter padding to uniformly adjust with the size of the popover (#2207)
  • Fixed isDragDisabled prop usage in EuiDraggable (#2207)
  • Fixed EuiMutationObserver's handling ofonMutation when that prop's value changes (#2421)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@chandlerprall chandlerprall requested a review from a team as a code owner October 25, 2019 18:19
@thompsongl thompsongl added the release_note:skip Skip the PR/issue when compiling release notes label Oct 25, 2019
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. I added the release_note:skip label 👍

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you might need a snapshot? LGTM otherwise

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@chandlerprall chandlerprall requested a review from a team October 27, 2019 18:34
@chandlerprall chandlerprall requested a review from a team as a code owner October 27, 2019 18:34
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chandlerprall
Copy link
Contributor Author

For @elastic/kibana-canvas & @elastic/kibana-app pings, this is an EUI upgrade PR where some jest tests and snapshots were updated to stay current.

@chandlerprall chandlerprall merged commit 94202a9 into elastic:master Oct 29, 2019
@chandlerprall chandlerprall deleted the eui-14.8.0 branch October 29, 2019 17:04
chandlerprall added a commit to chandlerprall/kibana that referenced this pull request Oct 29, 2019
* Upgrade EUI to v14.8.0

* update snapshot for determinism
chandlerprall added a commit that referenced this pull request Oct 29, 2019
* Upgrade EUI to v14.8.0

* update snapshot for determinism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants