-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v14.8.0 #49375
Upgrade EUI to v14.8.0 #49375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. I added the release_note:skip
label 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you might need a snapshot? LGTM otherwise
💔 Build Failed
|
💔 Build Failed
|
23e05b0
to
210477b
Compare
💚 Build Succeeded |
For @elastic/kibana-canvas & @elastic/kibana-app pings, this is an EUI upgrade PR where some jest tests and snapshots were updated to stay current. |
* Upgrade EUI to v14.8.0 * update snapshot for determinism
Summary
Upgrades EUI from 14.7.0 to 14.8.0, this is a release of
EuiDataGrid
and some related bug fixes and enhancements to other components.The unit test changes are a result of an accessibility change which removed a selector used by a couple tests. I've updated the selector to an equally bad choice (eh, maybe a little better), but EUI's table pagination doesn't give much to work with right now.
One change introduced the typo'd
aira-modal
attribute, there is a subsequent fix for this which we'll make sure follows this PR into the 7.x branch.14.8.0
EuiButtonGroup
andEuiButtonToggle
now acceptReactNode
for their label prop instead of string (#2392)useRenderToText
toinner_text
service suite to renderReactNode
s into label text (#2392)tableDensityExpanded
,tableDensityCompact
,tableDensityNormal
toEuiIcon
(#2230)!important
to the animation ofEuiFocusRing
animation to make sure it is always used (#2230)expandMini
icon toEuiIcon
(#2207)EuiPopover
to userole="dialog"
for better screen-reader announcements (#2207)onTrapDeactivation
toEuiPopover
for when a focus trap is deactivated (#2366)EuiPopover
to counteract a race condition (#2366)EuiDataGrid
(#2165)Bug fixes
lockProps
passdown inEuiFocusTrap
, specifically to allowsstyle
to be passed down. (#2230)children
property onI18nTokensShape
type from a singleReactChild
to now accept anarray
(#2230)$euiColorHighlight
in dark mode (#2176)EuiPopoverFooter
padding to uniformly adjust with the size of the popover (#2207)isDragDisabled
prop usage inEuiDraggable
(#2207)EuiMutationObserver
's handling ofonMutation
when that prop's value changes (#2421)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately