[backport] Fixing old backport for content-disposition in reporting #49249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this fixes a backport that did not work perfectly? Can we link to that backport PR here? That will give us a fuller picture |
|
Original backport is here: #31713 EDIT: it does look like my backport ended up in the wrong spot since I don't see the old JS version being deleted. It's possible that my fix was based upon the new file-system changes, and the backporting tool didn't really "catch" it. I think from now on:
|
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an older backport get merged, but then get orphaned in a file-system change. This PR fixes that, assuming we want this change and are going to do another 6-series release.