Merged Pull Request #484 #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Sep 13, 2018
* chore: rewrite fullscreen component use component syntax, simply tie into redux in index * chore: remove conditional fullscreen controls * chore: rewrite fullscreen control and service fullscreen toggle is entired managed in state, and the control simply wraps keybindings and sets the state * fix: tweak styles for fullscreen greatness * fix: page hotkeys in fullscreen mode * feat: replicate edit page keys in presentation mode * chore: move fullscreen service to middleware * fix: use classList for fullscreen * fix: remove id passing in fullscreen component it's not used, or really even useful, and can be put back if we need it * fix: no scrolling when scaling below 1 * chore: fix imports, drop file extensions
spalger
pushed a commit
that referenced
this pull request
Oct 29, 2019
* move react/jsx-a11y rules into shared react preset * autofix react/jsx-closing-tag-location * autofix react/no-unknown-property * manually fix react/no-unescaped-entities * maually fix react/jsx-pascal-case * manually fix react/prefer-stateless-function * disable known violations in specific plugins/areas * remove code override # Conflicts: # x-pack/legacy/plugins/upgrade_assistant/public/components/tabs/checkup/deprecations/reindex/flyout/warnings_step.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified version of #484 that should merge cleanly.