Upgrade EUI to 14.7.0

[thompsongl]

Most of the changes are from updated icons: ifraApp became metricsApp, and loggingApp became logsApp.

---

14.7.0

• Converted EuiRadio and EuiRadioGroup to TypeScript (#2438)
• Improved a11y in EuiImage (#2447)
• Made EuiIcon a PureComponent, to speed up React re-render performance (#2448)
• Added ability for EuiColorStops to accept user-defined range bounds (#2396)
• Added external prop to EuiLink (#2442)
• Added disabled state to EuiBadge (#2440)
• Changed EuiLink to appear non interactive when passed the disabled prop and an onClick handler (#2423)
• Added minimize glyph to EuiIcon (#2457)

Bug fixes

• Reenabled width property for EuiTable cell components (#2452)
• Fixed EuiNavDrawer collapse/expand button height issue
  (#2463)

14.6.0

• Added new updated infraApp and logsApp icons. (#2430)

Bug fixes

• Fixed missing misc. button and link type definition exports (#2434)
• Strip custom semantics from EuiSideNav (#2429)

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: f9e6e86

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 14035b8

[walterra]

ML changes LGTM

[dgieselaar]

APM changes LGTM

[afgomez]

[nitpicking] should we rename the SVGs as well to keep the naming consistent?

[thompsongl]

I'll leave that decision up to you all; I'm not sure how much infra-to-metrics language conversion is planned for the app. The underlying image actually changed during the switch from infraApp to metricsApp. Plus, that name is part of the EUI API, so there is some necessity for EUI to align with the direction.

[chandlerprall]

Code, package, and yarn.lock changes LGTM

[clintandrewhall]

@thompsongl @chandlerprall Bummer... this change ended up breaking Canvas assets. (#50733) The Storybook Jest tests caught the change, but the snapshots were simply regenerated, rather than confirmed through the Storybook tool. I'm also a bit concerned this PR was only open for a day, and Canvas isn't a sign-off on the PR...?

It's awesome that #43529 is coming, which will make Storybook more mainstream, so it'll be easy to visually confirm changes. Aside from that, how can we prevent this kind of issue moving forward?

cc: @poffdeluxe

[chandlerprall]

Thank you for bringing this up! I want to shed a little light on what happened & our process, and then go from there.

1. the EUI change that broke canvas assets was made too flippantly, without consideration for existing uses
2. our upgrade path includes running jest with the update snapshots flag, and then manually checking the updated files. Looking at the diff on this PR again, the change in asset.examples.storyshot should have been caught and verified but was not
3. I share your concern in skipping any team's approval on these. We've taken the approach that - while we appreciate and prefer getting those approvals - if one was triggered solely by snapshot changes and we can account for that change in EUI's changelog, then we will proceed after a short wait. Depending on urgency (either real or felt), this could be same day or a few days later.

Given 1&2, we had a couple points in time where we could have caught this but didn't, and I think this has to be expected in any manual process - though we can and should take steps to limit it further. Some further thoughts/questions:

• can jest be configured to not auto-update storyshots / can there be a forcing function to use storybook to confirm these changes
• we should follow-up to get a team involved (via that team's slack channel?) before merging
• ? open to any ideas, especially if it can be automated ?

[clintandrewhall]

@chandlerprall Gotcha... given the constraints/considerations, I think integrating Percy into our Storybook setup(s) will make this a ton easier to confirm moving forward. I also think encouraging snapshot tests be generated via Storybook examples, (using #43529), rather than in pure code, we can make it much easier for EUI and others to visually confirm passive changes.

In the short term, I think if jest is run with --update out of the gate, we're just going to have to live with a few missteps from time-to-time.

[thompsongl]

Apologies for the misstep here, @clintandrewhall. Definitely some boxes left unchecked in this particular PR when it came to preventing breaks.

Percy integration would be hugely helpful for EUI upgrade PRs. In the meantime, delaying the merge for a while and making sure your team has a chance to review is the minimum we can do.