-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Gracefully handle issue with filebeat indices #48929
[Monitoring] Gracefully handle issue with filebeat indices #48929
Conversation
Pinging @elastic/stack-monitoring (Team:Monitoring) |
I will test this shortly and do a code review but in general, is the precedence for linking to GH issues from the interface? It seems like the remediation steps are straightforward enough that we could probably just include them in the copy we display in the app. |
@cachedout Good question. I'm not sure - I wasn't sure we had enough space to contain the full steps to fix this. |
💔 Build Failed |
I played around with options and this is the shortest copy I could come up with that fit in the constraints of the box on the page:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left an alternate for the copy in the comments of this PR if you want to use it but I think it's just fine to merge as-is.
My only concern with this is users don't technically need to delete the ILM-based indices, such as |
Just to offer an alternate solution: if we're going to link off to somewhere, perhaps we should link off to a section in https://www.elastic.co/guide/en/kibana/current/monitor-troubleshooting.html instead of a GitHub issue? [EDIT] That said, I agree that if we can get away with not linking off to something externally but instead presenting the workaround in the app itself, that would be better. |
👍 to this suggestion. This is a great idea. |
@cachedout Do you mind handling that PR separately? to update the that doc page to add this information? Then we can merge this PR with the updated link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
💔 Build Failed |
It's linked above but just to be clear, the PR with the copy for this is #49065 |
* Add filebeat notice Refs #48929 * Update docs/user/monitoring/monitoring-troubleshooting.asciidoc Co-Authored-By: Lisa Cawley <[email protected]> * Update docs/user/monitoring/monitoring-troubleshooting.asciidoc Co-Authored-By: Lisa Cawley <[email protected]> * Update docs/user/monitoring/monitoring-troubleshooting.asciidoc Co-Authored-By: Lisa Cawley <[email protected]> * Update docs/user/monitoring/monitoring-troubleshooting.asciidoc Co-Authored-By: Lisa Cawley <[email protected]> * Update docs/user/monitoring/monitoring-troubleshooting.asciidoc Co-Authored-By: Lisa Cawley <[email protected]> * Update docs/user/monitoring/monitoring-troubleshooting.asciidoc Co-Authored-By: Lisa Cawley <[email protected]> * Fixup per review comments
@igoristic @cachedout I updated this PR with the trouble shooting link based on the changes @cachedout made in #49065. Ready for another round |
💚 Build Succeeded |
x-pack/legacy/plugins/monitoring/server/lib/logs/detect_reason_from_exception.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
…8929) * Gracefully handle issue with filebeat indices * Update translation keys * Update link * Add in default, per PR comment
…8929) * Gracefully handle issue with filebeat indices * Update translation keys * Update link * Add in default, per PR comment
I was mid-review when this got merged but I'm finished now and all looks well. :) 👍 |
@cachedout Ah, my bad! I figured it was good to go since it was a small change since your comment |
…-fallback * 'master' of github.com:elastic/kibana: (116 commits) [Maps] move apply global filter settting from layer to source (elastic#50523) [SIEM] Fix: Empty `Source` / `Destination` shown when only ports are populated (elastic#50843) [Maps] Delay vector tile layer syncing until spritesheet is loaded (elastic#48955) [Maps] prevent users from overflowing URL when filtering by shape (elastic#50747) [DOCS] Mark Beats central management as discontinued (elastic#49423) [page_objects/common_page] convert to ts (elastic#50771) [NP Kibana Migrations ] kibana plugin home (elastic#50444) [DOCS] Shareables naming convention (elastic#50497) [ML] DF Analytics - auto-populate model_memory_limit (elastic#50714) Increase alerting test stability and reduce flakiness (elastic#50246) [ML] Remaning new_job_new folder (elastic#50917) [Telemetry] Show opt-in changes for OSS users (elastic#50831) [ML] Fix lat_long anomalies table links menu and value formatting (elastic#50916) [Dev] Fix serialising a really big string (elastic#50915) Better explanation about the Prettier recommendation (extension vs. NPM module) (elastic#50629) [Monitoring] Use a basic monitoring user for tests (elastic#47865) [Monitoring] Gracefully handle issue with filebeat indices (elastic#48929) [Monitoring] Improve permissions required around setup mode (elastic#50421) Additional validation for elasticsearch username (elastic#48247) Revert changes to use_kibana_ui_setting (elastic#50877) ... # Conflicts: # src/legacy/core_plugins/console/server/request.test.ts
Resolves #48533
Feel free to suggest better copy!
To test,
DELETE filebeat-*
GET _cat/indices
and verify you see anfilebeat-${VERSION}
index