Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Gracefully handle issue with filebeat indices #48929

Merged

Conversation

chrisronline
Copy link
Contributor

Resolves #48533

Feel free to suggest better copy!

Screen Shot 2019-10-22 at 12 04 08 PM

To test,

  1. Install and configure filebeat to ship elasticsearch logs to your local cluster
  2. Enable monitoring
  3. Open stack monitoring UI and verify the logs are visible
  4. In dev tools, run DELETE filebeat-*
  5. Run some more commands in dev tools to generate more ES logs
  6. Check GET _cat/indices and verify you see an filebeat-${VERSION} index
  7. Go back and refresh the stack monitoring UI and verify the page loads with the logs panel showing the error shown above

@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@cachedout
Copy link
Contributor

I will test this shortly and do a code review but in general, is the precedence for linking to GH issues from the interface? It seems like the remediation steps are straightforward enough that we could probably just include them in the copy we display in the app.

@chrisronline
Copy link
Contributor Author

@cachedout Good question. I'm not sure - I wasn't sure we had enough space to contain the full steps to fix this.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cachedout
Copy link
Contributor

I played around with options and this is the shortest copy I could come up with that fit in the constraints of the box on the page:

There is an issue reading from your filebeat indices. Stop Filebeat, delete indices that start with `filebeat-*` and then restart Filebeat.```

That said, I don't have any objection to just linking to the issue, and that may actually be a better experience for the user. 




Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left an alternate for the copy in the comments of this PR if you want to use it but I think it's just fine to merge as-is.

@chrisronline
Copy link
Contributor Author

There is an issue reading from your filebeat indices. Stop Filebeat, delete indices that start with filebeat-* and then restart Filebeat.

My only concern with this is users don't technically need to delete the ILM-based indices, such as filebeat-8.0.0-2019.10.23-000001. Those will correctly match the template - it's only filebeat-${VERSION} indices that are affected by this

@ycombinator
Copy link
Contributor

ycombinator commented Oct 23, 2019

Just to offer an alternate solution: if we're going to link off to somewhere, perhaps we should link off to a section in https://www.elastic.co/guide/en/kibana/current/monitor-troubleshooting.html instead of a GitHub issue?

[EDIT] That said, I agree that if we can get away with not linking off to something externally but instead presenting the workaround in the app itself, that would be better.

@cachedout
Copy link
Contributor

Just to offer an alternate solution: if we're going to link off to somewhere, perhaps we should link off to a section in elastic.co/guide/en/kibana/current/monitor-troubleshooting.html instead of a GitHub issue?

👍 to this suggestion. This is a great idea.

@chrisronline
Copy link
Contributor Author

@cachedout Do you mind handling that PR separately? to update the that doc page to add this information? Then we can merge this PR with the updated link

cachedout added a commit to cachedout/kibana that referenced this pull request Oct 23, 2019
@cachedout cachedout mentioned this pull request Oct 23, 2019
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cachedout
Copy link
Contributor

It's linked above but just to be clear, the PR with the copy for this is #49065

cachedout added a commit that referenced this pull request Nov 14, 2019
* Add filebeat notice

Refs #48929

* Update docs/user/monitoring/monitoring-troubleshooting.asciidoc

Co-Authored-By: Lisa Cawley <[email protected]>

* Update docs/user/monitoring/monitoring-troubleshooting.asciidoc

Co-Authored-By: Lisa Cawley <[email protected]>

* Update docs/user/monitoring/monitoring-troubleshooting.asciidoc

Co-Authored-By: Lisa Cawley <[email protected]>

* Update docs/user/monitoring/monitoring-troubleshooting.asciidoc

Co-Authored-By: Lisa Cawley <[email protected]>

* Update docs/user/monitoring/monitoring-troubleshooting.asciidoc

Co-Authored-By: Lisa Cawley <[email protected]>

* Update docs/user/monitoring/monitoring-troubleshooting.asciidoc

Co-Authored-By: Lisa Cawley <[email protected]>

* Fixup per review comments
@chrisronline
Copy link
Contributor Author

@igoristic @cachedout I updated this PR with the trouble shooting link based on the changes @cachedout made in #49065. Ready for another round

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@igoristic igoristic self-requested a review November 17, 2019 23:17
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chrisronline chrisronline merged commit f92573a into elastic:master Nov 18, 2019
@chrisronline chrisronline deleted the monitoring/bad_filebeat_indices branch November 18, 2019 15:49
chrisronline added a commit to chrisronline/kibana that referenced this pull request Nov 18, 2019
…8929)

* Gracefully handle issue with filebeat indices

* Update translation keys

* Update link

* Add in default, per PR comment
chrisronline added a commit to chrisronline/kibana that referenced this pull request Nov 18, 2019
…8929)

* Gracefully handle issue with filebeat indices

* Update translation keys

* Update link

* Add in default, per PR comment
@cachedout
Copy link
Contributor

I was mid-review when this got merged but I'm finished now and all looks well. :) 👍

@chrisronline
Copy link
Contributor Author

@cachedout Ah, my bad! I figured it was good to go since it was a small change since your comment

chrisronline added a commit that referenced this pull request Nov 18, 2019
…50923)

* Gracefully handle issue with filebeat indices

* Update translation keys

* Update link

* Add in default, per PR comment
chrisronline added a commit that referenced this pull request Nov 18, 2019
…50924)

* Gracefully handle issue with filebeat indices

* Update translation keys

* Update link

* Add in default, per PR comment
@chrisronline
Copy link
Contributor Author

Backport:

7.x: 4a336be
7.5: 3a476ec
7.4: c611890

jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 18, 2019
…-fallback

* 'master' of github.com:elastic/kibana: (116 commits)
  [Maps] move apply global filter settting from layer to source (elastic#50523)
  [SIEM] Fix: Empty `Source` / `Destination` shown when only ports are populated (elastic#50843)
  [Maps] Delay vector tile layer syncing until spritesheet is loaded (elastic#48955)
  [Maps] prevent users from overflowing URL when filtering by shape (elastic#50747)
  [DOCS] Mark Beats central management as discontinued (elastic#49423)
  [page_objects/common_page] convert to ts (elastic#50771)
  [NP Kibana Migrations ] kibana plugin home (elastic#50444)
  [DOCS] Shareables naming convention (elastic#50497)
  [ML] DF Analytics - auto-populate model_memory_limit (elastic#50714)
  Increase alerting test stability and reduce flakiness (elastic#50246)
  [ML] Remaning new_job_new folder (elastic#50917)
  [Telemetry] Show opt-in changes for OSS users (elastic#50831)
  [ML] Fix lat_long anomalies table links menu and value formatting (elastic#50916)
  [Dev] Fix serialising a really big string (elastic#50915)
  Better explanation about the Prettier recommendation (extension vs. NPM module) (elastic#50629)
  [Monitoring] Use a basic monitoring user for tests (elastic#47865)
  [Monitoring] Gracefully handle issue with filebeat indices (elastic#48929)
  [Monitoring] Improve permissions required around setup mode (elastic#50421)
  Additional validation for elasticsearch username (elastic#48247)
  Revert changes to use_kibana_ui_setting (elastic#50877)
  ...

# Conflicts:
#	src/legacy/core_plugins/console/server/request.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitoring] Monitoring UI breaks with missings filebeat mappings
5 participants