[Reporting/New Platform] Prepare Typedefs for Legacy Shimming #48825
Conversation
tsullivan
added
review
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
| @@ -182,22 +177,23 @@ export const reporting = (kibana) => { | |||
| }).default(); | |||
| }, | |||
|
|
|||
| // TODO: Decouple Hapi: Build a server facade object based on the server to | |||
| // pass through to the libs. Do not pass server directly | |||
There was a problem hiding this comment.
Added this comment to point out the next step to do for migration. See https://github.com/elastic/kibana/blob/master/src/core/MIGRATION.md#de-couple-from-hapijs-server-and-request-objects
| @@ -193,13 +242,6 @@ export interface ExportTypeDefinition { | |||
| validLicenses: string[]; | |||
| } | |||
|
|
|||
| // Note: this seems to be nearly a duplicate of ExportTypeDefinition | |||
| export interface ExportType { | |||
There was a problem hiding this comment.
Removed this because it was duplicate of ExportTypeDefinition
| server.route({ | ||
| path: `${BASE_GENERATE}/{p*}`, | ||
| method: 'GET', | ||
| config: getRouteConfig(), |
There was a problem hiding this comment.
This was removed because the routing middleware this adds is not applicable to the GET request for this.
tsullivan
force-pushed
the
reporting/new-platform-shim-part-i
branch
from
6c46e61 to
6de1d4b
Compare
💚 Build Succeeded |
| @@ -21,15 +22,15 @@ import { clean } from './clean'; | |||
| * @return {Promise<undefined>} | |||
| */ | |||
| export async function ensureBrowserDownloaded(browserType: BrowserType) { | |||
| await ensureDownloaded([BROWSERS_BY_TYPE[browserType]]); | |||
| await ensureDownloaded([chromium]); | |||
|
LGTM, seems mostly Type/name changes from what I read. Did you have any other concerns @tsullivan? |
Nope, no concerns. The purpose is just to get rid of our custom types that are provided by the core legacy framework, and get rid of direct references to Hapi. |
…c#48825) * [Reporting/New Platform] Prepare Typedefs for Legacy Shim * cleanup redundant * fix opts.interval / opts.pollInterval * comment on next todo * fix pretty * captureconfig typo * fix typescript conflict with shim * clean up loc * custom response toolkit type * remove unecessary route options * move getRouteOptions CSV * fix route configs * cleanup * split up type exports * fix types * fix ts errors * remove an any type
#49124) * [Reporting/New Platform] Prepare Typedefs for Legacy Shim * cleanup redundant * fix opts.interval / opts.pollInterval * comment on next todo * fix pretty * captureconfig typo * fix typescript conflict with shim * clean up loc * custom response toolkit type * remove unecessary route options * move getRouteOptions CSV * fix route configs * cleanup * split up type exports * fix types * fix ts errors * remove an any type
Summary
This PR continues New Platform migration for Reporting.
KbnServertype with newServerFacadetype based onLegacy.ServerRequestFacadetype andLegacy.*types.configfields inserver.routeobject tooptions(configwas deprecated in Hapi v17)Release Notes: Changes to prepare Reporting for Kibana v8.0.0
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility