Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Use full time range for the x-axis domain #48754

Merged
merged 3 commits into from
Oct 23, 2019
Merged

[Logs UI] Use full time range for the x-axis domain #48754

merged 3 commits into from
Oct 23, 2019

Conversation

Kerry350
Copy link
Contributor

Summary

Fixes #48385

@Kerry350 Kerry350 added release_note:fix v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 labels Oct 21, 2019
@Kerry350 Kerry350 requested a review from a team October 21, 2019 12:17
@Kerry350 Kerry350 self-assigned this Oct 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Zacqary
Zacqary reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense; where can I find a good set of data to test this? Is there a time range on one of the shared clusters that shows off the bugfix well?

@Kerry350
Copy link
Contributor Author

@Zacqary The 8.x.x cluster has small periods with data missing over all of October, so you should be able to zone in on one of those quite easily.

@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Kerry350 Kerry350 merged commit 3a6d0d0 into elastic:master Oct 23, 2019
Kerry350 added a commit to Kerry350/kibana that referenced this pull request Oct 23, 2019
@Kerry350
Use full time interval for x-axis domain (elastic#48754)
05d99b8
@Kerry350 Kerry350 mentioned this pull request Oct 23, 2019
Merged
Kerry350 added a commit to Kerry350/kibana that referenced this pull request Oct 23, 2019
@Kerry350
Use full time interval for x-axis domain (elastic#48754)
4517a70
@Kerry350 Kerry350 mentioned this pull request Oct 23, 2019
Merged
Kerry350 added a commit that referenced this pull request Oct 23, 2019
@Kerry350
Use full time interval for x-axis domain (#48754) (#49051)
5ead0e1
Kerry350 added a commit that referenced this pull request Oct 24, 2019
@Kerry350
Use full time interval for x-axis domain (#48754) (#49052)
e36ca7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zacqary Zacqary Zacqary approved these changes

Assignees

@Kerry350 Kerry350

Labels
Feature:Logs UI Logs UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs UI] Analysis charts don't show the full selected time interval
3 participants
@Kerry350 @elasticmachine @Zacqary