Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Fix page layout #48628

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

walterra
Copy link
Contributor

Summary

Part of #45352.

Fixes the overall page layout of the transform plugin to be in line with the rest of the Kibana Elasticsearch management section:

  • Wraps the whole page in a panel
  • Adds links to documentation
  • Adds a subheading with description (transform list)
  • Moves the refresh and create button to the table search section (transform list)

Transform List

image

Transform Wizard

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@walterra walterra added bug Fixes for quality problems that affect the customer experience regression :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.5.0 v7.6.0 labels Oct 18, 2019
@walterra walterra requested review from a team as code owners October 18, 2019 11:08
@walterra walterra self-assigned this Oct 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a test and LGTM ⚡️

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit e60a5b0 into elastic:master Oct 21, 2019
@walterra walterra deleted the ml-transform-fix-layout branch October 21, 2019 08:38
walterra added a commit to walterra/kibana that referenced this pull request Oct 21, 2019
Fixes the overall page layout of the transform plugin to be in line with the rest of the Kibana Elasticsearch management section.
walterra added a commit to walterra/kibana that referenced this pull request Oct 21, 2019
Fixes the overall page layout of the transform plugin to be in line with the rest of the Kibana Elasticsearch management section.
walterra added a commit that referenced this pull request Oct 21, 2019
Fixes the overall page layout of the transform plugin to be in line with the rest of the Kibana Elasticsearch management section.
walterra added a commit that referenced this pull request Oct 21, 2019
Fixes the overall page layout of the transform plugin to be in line with the rest of the Kibana Elasticsearch management section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml regression release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants