-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps][File upload] Add buffer to chunk size to prevent risk of oversize post requests #48595
Merged
kindsun
merged 3 commits into
elastic:master
from
kindsun:fix-chunk-exceeding-post-limits
Oct 31, 2019
Merged
[Maps][File upload] Add buffer to chunk size to prevent risk of oversize post requests #48595
kindsun
merged 3 commits into
elastic:master
from
kindsun:fix-chunk-exceeding-post-limits
Oct 31, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Feature:File Upload
v7.5.0
labels
Oct 17, 2019
Pinging @elastic/kibana-gis (Team:Geo) |
💚 Build Succeeded |
@elasticmachine merge upstream |
💚 Build Succeeded |
@elasticmachine merge upstream |
💚 Build Succeeded |
thomasneirynck
added
v7.6.0
release_note:fix
v7.5.0
release_note:skip
Skip the PR/issue when compiling release notes
and removed
v7.5.0
release_note:skip
Skip the PR/issue when compiling release notes
release_note:fix
labels
Oct 31, 2019
thomasneirynck
approved these changes
Oct 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, nice layer btw.
I'd not backport to 7.5, but it's a small enough change. up2you.
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Oct 31, 2019
kindsun
pushed a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
Feature:File Upload
release_note:skip
Skip the PR/issue when compiling release notes
v7.6.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #45510. The logic currently used to chunk up a
FeatureCollection
across several posts on the client uses the same limit constantMAX_BYTES
used on the server as a POST request size limit. The problem that occasionally arises is when an array of features assigned to a chunk come so close to theMAX_BYTES
limit, that the remaining POST content that's added is enough to push the overall POST over the size limit. This PR just subtracts a 2MB buffer from theMAX_BYTES
size to create amaxByteSize
chunk limit that allows room for remaining POST content to be added without exceeding the server's limits.Steps to test locally
Note: With this particular file there are several features which fail to index due to Elasticsearch errors, this is not related to this issue.
buildings-46900-mini.geo.json.tar.gz