Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps][File upload] Add buffer to chunk size to prevent risk of oversize post requests #48595

Merged
merged 3 commits into from
Oct 31, 2019

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Oct 17, 2019

Summary

Resolves #45510. The logic currently used to chunk up a FeatureCollection across several posts on the client uses the same limit constant MAX_BYTES used on the server as a POST request size limit. The problem that occasionally arises is when an array of features assigned to a chunk come so close to the MAX_BYTES limit, that the remaining POST content that's added is enough to push the overall POST over the size limit. This PR just subtracts a 2MB buffer from the MAX_BYTES size to create a maxByteSize chunk limit that allows room for remaining POST content to be added without exceeding the server's limits.

Steps to test locally

  1. Unzip the attached file to get the GeoJSON file used in the original issue
  2. Upload the GeoJSON File using the Maps app

image

Note: With this particular file there are several features which fail to index due to Elasticsearch errors, this is not related to this issue.

buildings-46900-mini.geo.json.tar.gz

@kindsun kindsun added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:File Upload v7.5.0 labels Oct 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kindsun
Copy link
Contributor Author

kindsun commented Oct 25, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kindsun
Copy link
Contributor Author

kindsun commented Oct 29, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@thomasneirynck thomasneirynck requested a review from nreese October 31, 2019 15:44
@thomasneirynck thomasneirynck added v7.6.0 release_note:fix v7.5.0 release_note:skip Skip the PR/issue when compiling release notes and removed v7.5.0 release_note:skip Skip the PR/issue when compiling release notes release_note:fix labels Oct 31, 2019
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, nice layer btw.

I'd not backport to 7.5, but it's a small enough change. up2you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:File Upload release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Error on uploading a medium GeoJSON
3 participants