Debounce filter value suggestion refresh #48450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bargs
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build Succeeded |
TinaHeiligers
approved these changes
Oct 17, 2019
|
@Bargs can this get into 7.5.1 or has that ship sailed? |
|
@nerophon we generally only backport to patch releases if the issue is a severe kibana breaking bug or a security problem. |
💚 Build Succeeded |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Oct 18, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Oct 18, 2019
|
This is a bug fix and can still go into the 7.5 branch for the 7.5.0 release. It should not go into the 7.4 branch for the 7.4.1 patch release. |
Bargs
added a commit
that referenced
this pull request
Oct 21, 2019
Bargs
added a commit
that referenced
this pull request
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A customer reported that value suggestions were refreshing too quickly in the filter editor and putting a strain on their cluster. They tested 6.x vs 7.x and found that 7.x was refreshing on every keypress, whereas 6.x had a debounce. I looked back in the code and verified what they were saying. The refresh used to have a debounce but was lost in the React refactoring, so I've reintroduced it in this PR.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately