Pass raw values and format afterwards #48090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💔 Build Failed |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💔 Build Failed |
|
Jenkins, test this. |
💚 Build Succeeded |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 22, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 22, 2019
flash1293
added a commit
that referenced
this pull request
Oct 22, 2019
flash1293
added a commit
that referenced
this pull request
Oct 22, 2019
Merged
1 task
7 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #40334 and the same bug for IP ranges.
Date range and Ip range aggregations applied formatters to the value in the data table before passing it to the visualization. Because of this the raw values were not available for filter operations (e.g. when clicking a pie slice). The old solution attempted to parse the values out of the formatted value, but this fails in a couple of situations (e.g. when custom field formatters are applied to the values). This PR puts the raw values into the data table and makes sure the field formatter has all information to apply the correct format when actually showing the value to the user.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers