[Discover] Centralize dependencies in kibana_services.ts #48072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-07-np-move-doc-to-discover
kertal
added
Feature:Graph
💚 Build Succeeded |
46 tasks
kertal
changed the title
💔 Build Failed |
💔 Build Failed |
kertal
commented
Oct 24, 2019
| import { VISUALIZE_EMBEDDABLE_TYPE } from '../../../../../../src/legacy/core_plugins/kibana/public/visualize/embeddable'; | ||
| import { SEARCH_EMBEDDABLE_TYPE } from '../../../../../../src/legacy/core_plugins/kibana/public/discover/embeddable/constants'; |
There was a problem hiding this comment.
dear @elastic/kibana-canvas had to change this import, to ensure, that just this const is imported, and not all of our centralized dependencies of our Discover's NP refactoring
FYI: @flash1293 that's what caused the jest test to fail
kertal
commented
Oct 24, 2019
| @@ -23,4 +23,4 @@ | |||
| @import 'doc_viewer/index'; | |||
|
|
|||
| // Context styles | |||
| @import 'context/index'; | |||
| @import 'angular/context/index'; | |||
There was a problem hiding this comment.
Dear @elastic/kibana-design , valued owner and ruler of the 7 SCSS code kingdoms
There were just path changes in this PR.
Your humble servant
@kertal
💚 Build Succeeded |
flash1293
approved these changes
Oct 24, 2019
| import { TExecuteTriggerActions } from 'src/plugins/ui_actions/public'; | ||
| import { npStart, npSetup } from 'ui/new_platform'; |
There was a problem hiding this comment.
Looks like kibana_services can provide those.
There was a problem hiding this comment.
@flash1293 thx, yes, I've applied the changes, and tests look now good again 🎉
snide
approved these changes
Oct 24, 2019
💔 Build Failed |
|
@elasticmachine merge upstream |
…kertal/kibana into kertal-pr-2019-10-10-np-basic-structure
💚 Build Succeeded |
crob611
approved these changes
Oct 25, 2019
kertal
added a commit
that referenced
this pull request
Oct 28, 2019
kertal
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves most angular code / dependencies into the
angularsubfolder, centralizes dependencies inkibana_services.tsand implements a basic new platform plugin structureChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately