Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop /api/security/v1/saml route in favour of /api/security/saml/callback. #47929

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Oct 11, 2019

In #44513 we introduced new SAML callback route /api/security/saml/callback that should be used instead of /api/security/v1/saml. In this PR (8.0 only) we remove old route completely.

"Release Note: /api/security/v1/saml route is no longer available, /api/security/saml/callback route must be used instead. This change should be reflected in Kibana server.xsrf.whitelist config as well as in Elasticsearch and Identity Provider SAML settings."

@azasypkin azasypkin added chore release_note:breaking Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Authentication Platform Security - Authentication v8.0.0 labels Oct 11, 2019
@azasypkin azasypkin requested a review from a team as a code owner October 11, 2019 07:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@azasypkin azasypkin requested a review from kobelb October 11, 2019 09:26
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@azasypkin azasypkin merged commit f2ea5f9 into elastic:master Oct 14, 2019
@azasypkin azasypkin deleted the issue-xxx-saml-v1-drop branch October 14, 2019 10:47
darnautov pushed a commit to darnautov/kibana that referenced this pull request Oct 14, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@gchaps
Copy link
Contributor

gchaps commented Jan 24, 2020

@azasypkin Can you please document this change in the Breaking changes in 8.0 doc.

@azasypkin
Copy link
Member Author

@azasypkin Can you please document this change in the Breaking changes in 8.0 doc.

Thanks for catching this @gchaps! Created #56613. For some reason I thought that we have some automation in place that collects all release notes from PRs with release_note:breaking labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Security/Authentication Platform Security - Authentication release_note:breaking Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants