-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop /api/security/v1/saml
route in favour of /api/security/saml/callback
.
#47929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
chore
release_note:breaking
Team:Security
Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Feature:Security/Authentication
Platform Security - Authentication
v8.0.0
labels
Oct 11, 2019
Pinging @elastic/kibana-security (Team:Security) |
💚 Build Succeeded |
kobelb
approved these changes
Oct 11, 2019
watson
approved these changes
Oct 14, 2019
💚 Build Succeeded |
💔 Build Failed |
@azasypkin Can you please document this change in the Breaking changes in 8.0 doc. |
Thanks for catching this @gchaps! Created #56613. For some reason I thought that we have some automation in place that collects all release notes from PRs with |
This was referenced Oct 27, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Feature:Security/Authentication
Platform Security - Authentication
release_note:breaking
Team:Security
Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44513 we introduced new SAML callback route
/api/security/saml/callback
that should be used instead of/api/security/v1/saml
. In this PR (8.0 only) we remove old route completely./api/security/saml/callback
as Kibana ACS URL. elasticsearch#47999"Release Note:
/api/security/v1/saml
route is no longer available,/api/security/saml/callback
route must be used instead. This change should be reflected in Kibanaserver.xsrf.whitelist
config as well as in Elasticsearch and Identity Provider SAML settings."