UI settings move to NP #47590
Merged
UI settings move to NP #47590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Feature:New Platform
release_note:skip
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
commented
Oct 8, 2019
...ore/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.test.ts
Show resolved
Hide resolved
mshustov
commented
Oct 8, 2019
| }); | ||
|
|
||
| describe('getDefaults() argument', () => { | ||
| it('casts sync `getDefaults()` to promise', () => { |
There was a problem hiding this comment.
Not sure why it was done in this manner. Probably for the sake of consistency with other accessing methods.
mshustov
commented
Oct 8, 2019
| buildNum, | ||
| savedObjectsClient, | ||
| // we use a function for getDefaults() so that defaults can be different in | ||
| // different scenarios, and so they can change over time |
There was a problem hiding this comment.
It looks like a misleading comment. The platform calculates values once https://github.com/restrry/kibana/blob/b7114c7df6a547fbab769079589b5f755dc709bf/src/legacy/ui/ui_settings/ui_settings_mixin.js#L31
Dynamic behavior removed in c65da14#diff-a23948121f4bc50ced65723c687f343d
mshustov
commented
Oct 8, 2019
|
|
||
| server.decorate('server', 'uiSettingsServiceFactory', (options = {}) => { | ||
| return uiSettingsServiceFactory(server, { | ||
| getDefaults, | ||
| overrides, |
There was a problem hiding this comment.
I found only savedObjectsClient passed as a parameter in the plugins code
💔 Build Failed
|
💔 Build Failed
|
💚 Build Succeeded
|
rudolf
approved these changes
Oct 15, 2019
...ore/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.test.ts
Show resolved
Hide resolved
joshdover
approved these changes
Oct 15, 2019
mshustov
force-pushed
the
ui-settings-move-np
branch
from
02d9657
to
1090981
Compare
💔 Build Failed |
💚 Build Succeeded |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Oct 16, 2019
* add tests for logWithMetadata in LP * allow passing metadata to log in NP & LP * move ui_settings_client to NP * add ui_settings config * add ui_settings_service * switch to NP logging * export types * bootstrap uiSettings service in NP * pass NP uiSettings to LP * move ui_settings mock to NP * add test for mixin and switch to NP logger * make UiSettingsClient.getDefaults sync as it is * ui_settings_client uses private fields * ui_settings_client uses private methods * keep uiSettings config validation in NP only * update mocks * core context should know it is mocked * add tests for ui_settings_service * remove unused code from ui_settings_mixin test * improve types in ui_settings_mixin test * gen docs * test moved to NP * set pkg version in tests explicitly * update mocks in tests * UiSettingsServiceSetup --> InternalUiSettingsServiceSetup * add links to types * address eli comment * regen docs * remove unused types
mshustov
added a commit
that referenced
this pull request
Oct 16, 2019
* add tests for logWithMetadata in LP * allow passing metadata to log in NP & LP * move ui_settings_client to NP * add ui_settings config * add ui_settings_service * switch to NP logging * export types * bootstrap uiSettings service in NP * pass NP uiSettings to LP * move ui_settings mock to NP * add test for mixin and switch to NP logger * make UiSettingsClient.getDefaults sync as it is * ui_settings_client uses private fields * ui_settings_client uses private methods * keep uiSettings config validation in NP only * update mocks * core context should know it is mocked * add tests for ui_settings_service * remove unused code from ui_settings_mixin test * improve types in ui_settings_mixin test * gen docs * test moved to NP * set pkg version in tests explicitly * update mocks in tests * UiSettingsServiceSetup --> InternalUiSettingsServiceSetup * add links to types * address eli comment * regen docs * remove unused types
21 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves UiSettingsClient creation to the NP API. We don't expose this API to the plugins, the only Legacy platform uses it under the hood.
If SavedObjectsClient is not available in the NP we can work around it and use one from LP. As suggested here.
That unblocks exposing UiSettings client via
RequestHandlerContext.Objections @elastic/kibana-platform ?
I'm going to move uiSettings routes to NP in the following PR
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers