Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Canvas][i18n] Sidebar (#46090) #47512

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Oct 7, 2019

Backports the following commits to 7.x:

    *  This is a combination of 5 commits.

    Extracts i18n strings from sidebar_content

    Extracts i18n strings from element_settings

    Extracted i18n strings from workpad_config

    Extracts i18n strings from page_config

    Extracts i18n strings from group_settings

    Extracts i18n strings from element_config and multi_element_settings

    Extracted remaining strings from element_config

    Extracts i18n strings from sidebar_header

    Extracts i18n strings from custom_element_modal

    Fixed file picker placeholder

    Fixed i18n ids

    * Alphabetize keys

    * Fixed save button label

    * fixed merge conflict
@cqliu1 cqliu1 added the backport label Oct 7, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cqliu1 cqliu1 merged commit 5ee5a82 into elastic:7.x Oct 7, 2019
@cqliu1 cqliu1 deleted the backport/7.x/pr-46090 branch October 7, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants