Move doc, doc_viewer, context to discover folder #47436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 tasks
💚 Build Succeeded |
kertal
added
release_note:skip
kertal
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build Succeeded |
Bargs
approved these changes
Oct 10, 2019
…-07-np-move-doc-to-discover
…-07-np-move-doc-to-discover
💚 Build Succeeded |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
…-07-np-move-doc-to-discover
💚 Build Succeeded |
snide
approved these changes
Oct 16, 2019
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Oct 16, 2019
* Move doc folder to discover folder * Move doc_viewer folder to discover folder * Move context folder to discover folder * Move context scss import to discover folder * Introduce angular folder, start migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
doc,doc_viewer,contexttodiscoverfolder, minor adaptions to the code just to make it work. Pre work for the new platform shimming.Before:
src/legacy/core_plugins/kibana/public/
After
src/legacy/core_plugins/kibana/public/
Furthermore: add
angularfolder to discover and movediscover.js(the controller), directives to it as a start (much more will follow)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately