Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add tests to create saved search based jobs #47323

Merged
merged 6 commits into from
Oct 7, 2019
Merged

[ML] Add tests to create saved search based jobs #47323

merged 6 commits into from
Oct 7, 2019

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Oct 4, 2019 •
edited
Loading

Summary

This PR adds tests for ML job creation based on saved searches (5 scenarios: filter, lucene query, kuery query, filter + lucene query, filter + kuery query).

High level test steps

  • Create multi metric job based on saved search
  • Verify detector preview takes the saved search into account (number of split cards, split card title)
  • Verify job details after creation, especially the processed records to see if the saved search has been applied correctly

Other changes

  • Add saved searches to ml/farequote archive and clean up some not needed fields
  • Create a new test folder anomaly_detection and move existing job wizard tests into it
  • Update job source selection service after reactification

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Oct 4, 2019
@pheyos pheyos requested a review from a team as a code owner October 4, 2019 12:53
@pheyos pheyos self-assigned this Oct 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@pheyos
Copy link
Member Author

pheyos commented Oct 6, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

darnautov
darnautov approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jgowdyelastic
jgowdyelastic approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit f5c6853 into elastic:master Oct 7, 2019
@pheyos pheyos deleted the saved_search_job_tests branch October 7, 2019 13:46
@pheyos pheyos mentioned this pull request Oct 7, 2019
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Oct 7, 2019
@pheyos
[ML] Add tests to create saved search based jobs (elastic#47323)
e99630e 
This PR adds tests for ML job creation based on saved searches
pheyos added a commit that referenced this pull request Oct 7, 2019
@pheyos
[ML] Add tests to create saved search based jobs (#47323) (#47460)
f12e6f1 
This PR adds tests for ML job creation based on saved searches
@pheyos pheyos mentioned this pull request Oct 8, 2019
Merged
5 tasks
jgowdyelastic
jgowdyelastic approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@darnautov darnautov darnautov approved these changes

@walterra walterra walterra approved these changes

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pheyos @elasticmachine @walterra @darnautov @jgowdyelastic