Embeddables 👉 New Platform #46771
Merged
Embeddables 👉 New Platform #46771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
added
Feature:Embedding
|
Pinging @elastic/kibana-app-arch |
💚 Build Succeeded |
ryankeairns
approved these changes
Sep 27, 2019
...ins/dashboard_embeddable_container/public/np_ready/public/tests/dashboard_container.test.tsx
Show resolved
Hide resolved
| @@ -2,7 +2,8 @@ | |||
| "id": "advanced_ui_actions", | |||
| "version": "kibana", | |||
| "requiredPlugins": [ | |||
| "embeddable" | |||
| "embeddable", | |||
| "ui_actions" | |||
There was a problem hiding this comment.
I think this will need to be uiActions, but until it's used... not really important.
stacey-gammon
approved these changes
Sep 27, 2019
mattkime
approved these changes
Sep 27, 2019
|
@stacey-gammon yes, there will be follow-up PRs. |
This was referenced Sep 27, 2019
streamich
added a commit
that referenced
this pull request
Sep 27, 2019
* chore: 🤖 move embeddable_api to NP "embeddable" plugin * fix: 🐛 fix TypeScript type check errors * fix: 🐛 fix TypeScript and build errors * test: 💍 fix Jest tests * fix: 🐛 fix translations * test: 💍 add Mocha mocks * fix: 🐛 change import syntax from function test sample plugin * fix: 🐛 revert canvas changes back and leave placeholders * chore: 🤖 revert more changes * chore: 🤖 revert more changes * fix: 🐛 fix TypeScript type check errors * fix: 🐛 fix functional test imports * fix: 🐛 fix x-pack Jest test importa * test: 💍 fix advanced_ui_actiosn import for tests
streamich
added
release_note:plugin_api_changes
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriatelyDev Docs
Embeddables API has been moved from
src/legacy/core_plugins/embeddable_apito theembeddableNew Platform plugin atsrc/plugins/embeddable.Now you can use Embeddables API in the New Platform by depending on
embeddableplugin and receiving it through the plugin dependencies. In the legacy Kibana platform you can access Embeddables thoughui/new_platformbackdoor.