Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Readme for EuiUtils #46736

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Added Readme for EuiUtils #46736

merged 2 commits into from
Sep 30, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Sep 26, 2019

Just something to reference for the NP plugin.

@joshdover Do you mind just doing a quick read to make sure I got it right?

@cchaos cchaos added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Sep 26, 2019
@cchaos cchaos requested a review from joshdover September 26, 2019 20:13
@elasticmachine
Copy link
Contributor

💚 Build Succeeded


<Chart>
<Settings theme={npStart.plugins.eui_utils.useChartsTheme()} />
</Chart>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to put this example in a function component:

export const MyComponent = () => (
  <Chart>
    <Settings theme={npStart.plugins.eui_utils.useChartsTheme()} />
  </Chart>
);

Copy link
Contributor Author

@cchaos cchaos Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks! Will update merge on passing test

@cchaos cchaos force-pushed the euiutil-plugin-readme branch from 3a69af1 to bc52827 Compare September 30, 2019 17:48
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cchaos cchaos merged commit a972486 into elastic:master Sep 30, 2019
@cchaos cchaos deleted the euiutil-plugin-readme branch September 30, 2019 19:13
cchaos added a commit that referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants