Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gte and lt symbols in range filter fileds and tooltip #46697

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

majagrubic
Copy link
Contributor

@majagrubic majagrubic commented Sep 26, 2019

Summary

Closes #45911.
Adds and < symbols as a prepend on the input fields in the editor:
Screenshot 2019-09-26 at 13 35 04

Adds and < symbols in the tooltip message:
Screenshot 2019-09-26 at 13 35 22

Note: this also changes axis label.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@majagrubic majagrubic force-pushed the maja/fix-45911 branch 2 times, most recently from 42f6746 to 4e95e6c Compare September 26, 2019 14:24
@elasticmachine
Copy link
Contributor

💔 Build Failed

@majagrubic majagrubic added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@majagrubic majagrubic added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Vis Editor Visualization editor issues release_note:enhancement v7.5.0 v8.0.0 labels Sep 26, 2019
@majagrubic majagrubic requested a review from timroes September 26, 2019 16:13
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested on Chrome Linux, works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Vis Editor Visualization editor issues release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range labels are ambiguous
3 participants