-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding gte and lt symbols in range filter fileds and tooltip #46697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
majagrubic
force-pushed
the
maja/fix-45911
branch
2 times, most recently
from
September 26, 2019 14:24
42f6746
to
4e95e6c
Compare
majagrubic
force-pushed
the
maja/fix-45911
branch
from
September 26, 2019 15:05
4e95e6c
to
113d13b
Compare
💔 Build Failed |
majagrubic
added
the
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
label
Sep 26, 2019
Pinging @elastic/kibana-app |
majagrubic
added
Feature:Aggregations
Aggregation infrastructure (AggConfig, esaggs, ...)
Feature:Vis Editor
Visualization editor issues
release_note:enhancement
v7.5.0
v8.0.0
labels
Sep 26, 2019
💚 Build Succeeded |
timroes
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested on Chrome Linux, works as expected.
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Sep 30, 2019
majagrubic
pushed a commit
that referenced
this pull request
Sep 30, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Aggregations
Aggregation infrastructure (AggConfig, esaggs, ...)
Feature:Vis Editor
Visualization editor issues
release_note:enhancement
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.5.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #45911.
Adds
≥
and<
symbols as a prepend on the input fields in the editor:Adds
≥
and<
symbols in the tooltip message:Note: this also changes axis label.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Documentation was added for features that require explanation or tutorialsFor maintainers