Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldFormat registry - use new platform ui settings #46542

Merged

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Sep 25, 2019

Summary

chrome.getUiSettingsClient(); => npStart.core.uiSettings; for the FieldFormatRegistery

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@mattkime mattkime closed this Sep 25, 2019
@mattkime mattkime reopened this Sep 25, 2019
@mattkime mattkime changed the title FieldFormat registry - sue new platform ui settings FieldFormat registry - use new platform ui settings Sep 25, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@mattkime mattkime force-pushed the FieldFormats_new-platform_uiSettings branch from 5a30eab to aaf9f2a Compare September 27, 2019 03:24
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mattkime mattkime marked this pull request as ready for review September 27, 2019 18:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label Sep 27, 2019
@mattkime
Copy link
Contributor Author

@elasticmachine update branch

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattkime mattkime merged commit a57a5e7 into elastic:master Sep 30, 2019
mattkime added a commit to mattkime/kibana that referenced this pull request Sep 30, 2019
mattkime added a commit that referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants