-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LogsUI] Use theme colors for the timeline background #46213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afgomez
added
release_note:fix
Feature:Logs UI
Logs UI feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
labels
Sep 20, 2019
Pinging @elastic/infra-logs-ui |
afgomez
changed the title
Use theme colors for the timeline background
[LogsUI] Use theme colors for the timeline background
Sep 20, 2019
💚 Build Succeeded |
jfsiii
reviewed
Sep 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't checkout & run but LGTM for syntax & variable choice
This allows the timeline to adapt to the Kibana dark mode setting
afgomez
force-pushed
the
45175-log-timeline-dark-mode
branch
from
September 30, 2019 07:30
52bc2af
to
c059201
Compare
💚 Build Succeeded |
Kerry350
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Nice one 🎉
afgomez
pushed a commit
to afgomez/kibana
that referenced
this pull request
Oct 4, 2019
This allows the timeline to adapt to the Kibana dark mode setting
afgomez
pushed a commit
that referenced
this pull request
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Logs UI
Logs UI feature
release_note:fix
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.5.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows the timeline to adapt to the Kibana dark mode setting. Fixes #45175
Light mode:
Dark mode: