Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LogsUI] Use theme colors for the timeline background #46213

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Sep 20, 2019

Summary

This allows the timeline to adapt to the Kibana dark mode setting. Fixes #45175

Light mode:
Screenshot 2019-09-19 at 18 49 02

Dark mode:
Screenshot 2019-09-19 at 18 48 41

@afgomez afgomez added release_note:fix Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 20, 2019
@afgomez afgomez requested a review from a team as a code owner September 20, 2019 09:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@afgomez afgomez added the v7.5.0 label Sep 20, 2019
@afgomez afgomez changed the title Use theme colors for the timeline background [LogsUI] Use theme colors for the timeline background Sep 20, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't checkout & run but LGTM for syntax & variable choice

This allows the timeline to adapt to the Kibana dark mode setting
@afgomez afgomez force-pushed the 45175-log-timeline-dark-mode branch from 52bc2af to c059201 Compare September 30, 2019 07:30
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@afgomez afgomez added the v8.0.0 label Sep 30, 2019
@Kerry350 Kerry350 self-requested a review September 30, 2019 10:10
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice one 🎉

@afgomez afgomez merged commit 3a7d9fa into elastic:master Sep 30, 2019
@afgomez afgomez deleted the 45175-log-timeline-dark-mode branch September 30, 2019 13:57
afgomez pushed a commit to afgomez/kibana that referenced this pull request Oct 4, 2019
This allows the timeline to adapt to the Kibana dark mode setting
afgomez pushed a commit that referenced this pull request Oct 4, 2019
This allows the timeline to adapt to the Kibana dark mode setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs UI] Time Scale on Mini Map doesn't support dark mode
4 participants