-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to 14.2.0 #46075
Merged
Merged
Upgrade EUI to 14.2.0 #46075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.5.0
EUI
labels
Sep 18, 2019
Code owners:I fixed 2 things:
|
chandlerprall
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json, yarn.lock, and snapshots changes LGTM
code changes look sane
💔 Build Failed |
💔 Build Failed |
@chandlerprall I'm so sorry, I rebased with master but forgot to pull down your commit first and it obliterated your fix. Do you mind pushing again? |
💔 Build Failed |
@cchaos pushed up again! |
THANK YOU!!! |
💚 Build Succeeded |
cchaos
added a commit
to cchaos/kibana
that referenced
this pull request
Sep 19, 2019
* Upgraded EUI to 14.2.0 * Remove form row + button shim * Uncomment compressed prop from EuiComboBoxes * Fix and/or simplify prepend/append usages * Update two test files to correctly call EuiRange's onChange prop
cchaos
added a commit
that referenced
this pull request
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
14.2.0
compressed
option tobuttonSize
prop of EuiButtonGroup (#2343)EuiCard
,EuiKeyPadMenuItem
andEuiKeyPadMenuItemButton
(#2333)
compressed
TS definitions toEuiComboBox
,EuiCheckboxGroup
,EuiCheckbox
,EuiFieldSearch
,EuiRadioGroup
,EuiSwitch
(#2338)EuiFormRow
andEuiButton
(#2338)[readOnly]
inputs (#2338)Bug fixes
onChange
TS defs for EuiRange (#2349)EuiPopover
(#2341)prepend
andappend
nodes that may be popovers or tooltips (#2338)14.1.1
Bug fixes
14.1.0
EuiSuggest
component (#2270)compressed
styling toEuiSwitch
(#2327)EuiBottomBar
,EuiHealth
andEuiImage
to TS (#2328)allowFullScreen
is true inEuiImage
(#2287)EuiColorPicker
to TypeScript (#2340)EuiColorPicker
(#2340)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately