Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visualize point series tests #46069

Merged
merged 4 commits into from
Sep 19, 2019
Merged

Fix visualize point series tests #46069

merged 4 commits into from
Sep 19, 2019

Conversation

dmlemeshko
Copy link
Member

Summary

Fix flaky tests. Closes #45970

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2019 •
edited by dmlemeshko
Loading

💚 Build Succeeded

15x passed

@dmlemeshko
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2019 •
edited by dmlemeshko
Loading

💚 Build Succeeded

15x passed

@rashmivkulkarni
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2019 •
edited by dmlemeshko
Loading

💚 Build Succeeded

15x passed

@rashmivkulkarni
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2019 •
edited by dmlemeshko
Loading

💚 Build Succeeded

15x passed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko dmlemeshko marked this pull request as ready for review September 19, 2019 08:58
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0 labels Sep 19, 2019
@dmlemeshko dmlemeshko requested a review from spalger September 19, 2019 09:06
@dmlemeshko
Copy link
Member Author

@spalger 60x times passed, I hope it is more stable now :)

spalger
spalger approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @dmlemeshko!

@dmlemeshko dmlemeshko merged commit 8cd22b7 into elastic:master Sep 19, 2019
@dmlemeshko dmlemeshko mentioned this pull request Sep 19, 2019
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 19, 2019
@dmlemeshko
Fix visualize point series tests (elastic#46069)
1516a7e 
* change interaction with 'select' element

* run ciGroup5 15x times

* Revert "run ciGroup5 15x times"

This reverts commit 9c19d9a.
dmlemeshko added a commit that referenced this pull request Sep 19, 2019
@dmlemeshko
Fix visualize point series tests (#46069) (#46159)
2d50a92 
* change interaction with 'select' element

* run ciGroup5 15x times

* Revert "run ciGroup5 15x times"

This reverts commit 9c19d9a.
@dmlemeshko
Copy link
Member Author

7.x 2d50a92

@dmlemeshko dmlemeshko deleted the fix/visualize-point-series-tests branch January 31, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@dmlemeshko @elasticmachine @rashmivkulkarni @spalger