Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Move ML "Data Frame Transforms" to Kibana management section "Transforms". #45880

Merged
merged 55 commits into from
Oct 9, 2019
Merged
Show file tree
Hide file tree
Changes from 43 commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
52421c3
[transform] Initial plugin setup.
walterra Sep 17, 2019
9ea0c26
[transform] Remove references to 'data frame'.
walterra Sep 17, 2019
8aa35c7
[transform] Fix imports and tests.
walterra Sep 17, 2019
2979b26
[transform] Remove references to 'dataframe'.
walterra Sep 17, 2019
f9cbfd8
[transform] Use 'transform' prefix instead of 'ml' in SCSS.
walterra Sep 18, 2019
b04fa4e
[transform] Fix translations.
walterra Sep 18, 2019
9a043eb
[transform] Fix types.
walterra Sep 19, 2019
c8dac54
[transform] Remove more data frame references.
walterra Sep 24, 2019
dedb788
[transform] Remove data frames from ml nav tabs.
walterra Sep 24, 2019
2874429
[transform] Move field types to type/fields.
walterra Sep 24, 2019
f56c3b1
[transform] Move Kibana api endpoints to plugins/transform.
walterra Sep 24, 2019
269165c
[transform] Fix interface usage.
walterra Sep 24, 2019
56e2741
[transform] Rename pages to sections.
walterra Sep 25, 2019
55b0063
[transform] Move permissions checks to transform plugin.
walterra Sep 25, 2019
21fc923
[transform] Remove functional navigation transfrom tests from machine…
walterra Sep 25, 2019
c804b37
[transform] Fix types.
walterra Sep 25, 2019
5f0454e
[transform] Fix tests.
walterra Sep 25, 2019
bf144f5
[transform] Fix tests. Removes deprecated code.
walterra Sep 25, 2019
842257b
[transform] Removes deprecated functional tests code.
walterra Sep 25, 2019
6a9b3a8
[transform] Fix translations.
walterra Sep 25, 2019
e0348f0
[transform] Fix tests.
walterra Sep 25, 2019
cc7e8c7
[transform] Adds source selection modal.
walterra Sep 26, 2019
63f0228
[transform] Fix saved searches.
walterra Sep 30, 2019
118896f
[transform] Fix tests.
walterra Oct 1, 2019
c565bf1
[transform] Fix tests.
walterra Oct 1, 2019
d13b06f
[transform] Renamed data_frame_new_pivot to new_transform.
walterra Oct 2, 2019
b709957
[transform] Fix breadcrumbs.
walterra Oct 2, 2019
5e21487
[transform] Text and formatting tweaks.
walterra Oct 2, 2019
ab32b76
[transform] Tweak section naming.
walterra Oct 2, 2019
1b3c20d
[transform] Tweak file structure and naming.
walterra Oct 2, 2019
45a6999
[transform] Tweak types.
walterra Oct 2, 2019
89cdaef
[transform] Deprecate cross-plugin imports from ML.
walterra Oct 3, 2019
a496525
[transform] Fix navigation.
walterra Oct 3, 2019
7429b4c
Merge branch 'master' into transform-plugin
walterra Oct 3, 2019
367c901
[transform] Fix master merge regressions.
walterra Oct 3, 2019
fca5504
[transform] Fix master merge regressions.
walterra Oct 3, 2019
7fdb978
Merge branch 'master' into transform-plugin
walterra Oct 7, 2019
8e0c5bd
[transform] NP improvements.
walterra Oct 7, 2019
1730751
Merge branch 'master' into transform-plugin
walterra Oct 7, 2019
4f05ebe
[transform] Consolidate i18n imports.
walterra Oct 7, 2019
e1320e6
[transform] Review feedback: Routing setup.
walterra Oct 7, 2019
ba80b40
[transform] Fix types, tests.
walterra Oct 8, 2019
ecc2c59
[transform] Review feedback: Fix texts.
walterra Oct 8, 2019
be3a66c
[transform] Fix EuiTabbedContent width for JSON views.
walterra Oct 9, 2019
0e12550
[transform] Simplify isTransformIdValid/isJobIdValid.
walterra Oct 9, 2019
ac5cfe7
[transform] Return early for JobIcon unset message.
walterra Oct 9, 2019
b2e5e11
[transform] Simplify toArray.
walterra Oct 9, 2019
7f5320f
[transform] Simplify StatsBar styles.
walterra Oct 9, 2019
370a9f2
[transform] Review feedback: Tweaks plugint.ts.
walterra Oct 9, 2019
1b34e00
[transform] Review feedback: Remove Fragment, remove unused code.
walterra Oct 9, 2019
6b40948
[transform] Change EuiHighlight to just strong.
walterra Oct 9, 2019
304b4c7
[transform] Remove unused code.
walterra Oct 9, 2019
f35e796
Merge branch 'master' into transform-plugin
walterra Oct 9, 2019
2f6848a
[transform] Increase upstreamPlugin.status.setMaxListeners to 21.
walterra Oct 9, 2019
89d3398
[transform] Review feedback: Fix hooks issue.
walterra Oct 9, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
/x-pack/test/functional/apps/machine_learning/ @elastic/ml-ui
/x-pack/test/functional/services/machine_learning/ @elastic/ml-ui
/x-pack/test/functional/services/ml.ts @elastic/ml-ui
/x-pack/legacy/plugins/transform/ @elastic/ml-ui

# Operations
/renovate.json5 @elastic/kibana-operations
Expand Down
1 change: 1 addition & 0 deletions x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"xpack.server": "legacy/server",
"xpack.snapshotRestore": "legacy/plugins/snapshot_restore",
"xpack.spaces": "legacy/plugins/spaces",
"xpack.transform": "legacy/plugins/transform",
"xpack.upgradeAssistant": "legacy/plugins/upgrade_assistant",
"xpack.uptime": "legacy/plugins/uptime",
"xpack.watcher": "legacy/plugins/watcher"
Expand Down
2 changes: 2 additions & 0 deletions x-pack/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import { fileUpload } from './legacy/plugins/file_upload';
import { telemetry } from './legacy/plugins/telemetry';
import { encryptedSavedObjects } from './legacy/plugins/encrypted_saved_objects';
import { snapshotRestore } from './legacy/plugins/snapshot_restore';
import { transform } from './legacy/plugins/transform';
import { actions } from './legacy/plugins/actions';
import { alerting } from './legacy/plugins/alerting';
import { lens } from './legacy/plugins/lens';
Expand Down Expand Up @@ -75,6 +76,7 @@ module.exports = function (kibana) {
infra(kibana),
taskManager(kibana),
rollup(kibana),
transform(kibana),
siem(kibana),
remoteClusters(kibana),
crossClusterReplication(kibana),
Expand Down
4 changes: 0 additions & 4 deletions x-pack/legacy/plugins/ml/common/types/audit_message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ export interface AnalyticsMessage extends AuditMessageBase {
analytics_id: string;
}

export interface TransformMessage extends AuditMessageBase {
transform_id: string;
}

export interface JobMessage extends AuditMessageBase {
job_id: string;
}
12 changes: 0 additions & 12 deletions x-pack/legacy/plugins/ml/common/types/privileges.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ export interface Privileges {
canDeleteFilter: boolean;
// File Data Visualizer
canFindFileStructure: boolean;
// Data Frame Transforms
canGetDataFrame: boolean;
canDeleteDataFrame: boolean;
canPreviewDataFrame: boolean;
canCreateDataFrame: boolean;
canStartStopDataFrame: boolean;
// Data Frame Analytics
canGetDataFrameAnalytics: boolean;
canDeleteDataFrameAnalytics: boolean;
Expand Down Expand Up @@ -65,12 +59,6 @@ export function getDefaultPrivileges(): Privileges {
canDeleteFilter: false,
// File Data Visualizer
canFindFileStructure: false,
// Data Frame Transforms
canGetDataFrame: false,
canDeleteDataFrame: false,
canPreviewDataFrame: false,
canCreateDataFrame: false,
canStartStopDataFrame: false,
// Data Frame Analytics
canGetDataFrameAnalytics: false,
canDeleteDataFrameAnalytics: false,
Expand Down
1 change: 0 additions & 1 deletion x-pack/legacy/plugins/ml/public/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import 'plugins/ml/jobs';
import 'plugins/ml/overview';
import 'plugins/ml/services/calendar_service';
import 'plugins/ml/components/messagebar';
import 'plugins/ml/data_frame';
import 'plugins/ml/data_frame_analytics';
import 'plugins/ml/datavisualizer';
import 'plugins/ml/explorer';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,6 @@ function getTabs(disableLinks: boolean): Tab[] {
}),
disabled: disableLinks,
},
{
id: 'data_frames',
name: i18n.translate('xpack.ml.navMenu.dataFrameTabLinkText', {
defaultMessage: 'Transforms',
}),
disabled: false,
},
{
id: 'data_frame_analytics',
name: i18n.translate('xpack.ml.navMenu.dataFrameAnalyticsTabLinkText', {
Expand All @@ -68,7 +61,6 @@ interface TabData {
const TAB_DATA: Record<TabId, TabData> = {
overview: { testSubject: 'mlMainTab overview', pathId: 'overview' },
anomaly_detection: { testSubject: 'mlMainTab anomalyDetection', pathId: 'jobs' },
data_frames: { testSubject: 'mlMainTab dataFrames' },
data_frame_analytics: { testSubject: 'mlMainTab dataFrameAnalytics' },
datavisualizer: { testSubject: 'mlMainTab dataVisualizer' },
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ const tabSupport: TabSupport = {
overview: null,
jobs: 'anomaly_detection',
settings: 'anomaly_detection',
data_frames: null,
data_frame_analytics: null,
datavisualizer: null,
filedatavisualizer: null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export function getTabs(tabId: TabId, disableLinks: boolean): Tab[] {
const TAB_MAP: Partial<Record<TabId, Tab[]>> = {
overview: [],
datavisualizer: [],
data_frames: [],
data_frame_analytics: [],
anomaly_detection: [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,4 @@
* you may not use this file except in compliance with the Elastic License.
*/

export {
StatsBar,
TransformStatsBarStats,
AnalyticStatsBarStats,
JobStatsBarStats,
} from './stats_bar';
export { StatsBar, AnalyticStatsBarStats, JobStatsBarStats } from './stats_bar';
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,12 @@ export interface JobStatsBarStats extends Stats {
activeDatafeeds: StatsBarStat;
}

export interface TransformStatsBarStats extends Stats {
batch: StatsBarStat;
continuous: StatsBarStat;
started: StatsBarStat;
}

export interface AnalyticStatsBarStats extends Stats {
started: StatsBarStat;
stopped: StatsBarStat;
}

type StatsBarStats = TransformStatsBarStats | JobStatsBarStats | AnalyticStatsBarStats;
type StatsBarStats = JobStatsBarStats | AnalyticStatsBarStats;
type StatsKey = keyof StatsBarStats;

interface StatsBarProps {
Expand Down
3 changes: 0 additions & 3 deletions x-pack/legacy/plugins/ml/public/data_frame/_index.scss

This file was deleted.

61 changes: 0 additions & 61 deletions x-pack/legacy/plugins/ml/public/data_frame/breadcrumbs.ts

This file was deleted.

12 changes: 0 additions & 12 deletions x-pack/legacy/plugins/ml/public/data_frame/index.ts

This file was deleted.

This file was deleted.

This file was deleted.

Loading