Remove injectI18n in management. #45876

sainthkh · 2019-09-17T09:44:17Z

Summary

Inspired by #44043. Related to #38610.

Update to recommended usage of localization, using i18n.translate instead of injected intl prop in Dashboard app.

According to the I18n doc, it is recommended to avoid injectI18n and use i18n.translate instead.

Notes

Most changes are simple: remove injectI18n, remove WrappedComponent, change intl to i18n.translate.
But as for Field.js, it wasn't simple. In jest test, Field.js uses setProps and it doesn't work with child node. It only works with the root node.. So, I had to remove all FormattedMessage from Field.js to use mount() function.
- That's why that change is separated from other changes.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

Note

I've used regex below to remove intl fast:

intl\.formatMessage\(\{\n\s+id:\s+('.*'),\n*
i18n.translate($1, {

I wrote it here for my later use or for others who want to do the similar job.

elasticmachine · 2019-09-17T09:44:19Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2019-09-17T09:44:19Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2019-09-21T00:38:13Z

Pinging @elastic/kibana-app-arch

mattkime · 2019-10-03T16:01:31Z

retest

elasticmachine · 2019-10-03T17:07:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: f1e941e6c3970705bef7209e539125f5908fb319

mattkime · 2019-10-03T17:12:52Z

Looks like there are more changes to src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/snapshots/field.test.js.snap than wanted.

mattkime · 2019-10-03T17:13:31Z

It might be easier to break this PR up into a series of smaller PRs particularly due to the failing functional tests

Fixes. Fixes.

This reverts commit bc909ac791160c32581097107dad13c184fc77cb.

sainthkh · 2019-10-03T23:44:39Z

After checking things out, I found that the cause of all those functional test failures was "not changing the name of a component". After fixing this, all functional tests and eslint test passed.
As setProps can be called only on the root instance (if not, an exception will be thrown), I removed all <FormattedMessage>s at that time. But after a while, I thought changing code for test code is not good. So, I decided to create wrapper component for tests.
const updated is added to get the updated render results. Without them, test fails. I guess this happens because tested component is not a root component.

mattkime · 2019-10-04T01:36:38Z

retest

sainthkh · 2019-10-04T02:49:21Z

...dex_patterns/edit_index_pattern/indexed_fields_table/components/table/__jest__/table.test.js

@@ -21,7 +21,7 @@ import React from 'react';
 import { shallow } from 'enzyme';
 import { shallowWithI18nProvider } from 'test_utils/enzyme_helpers';

-import { TableComponent } from '../table';
+import { Table } from '../table';


elasticmachine · 2019-10-04T02:50:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 26eadbe

mattkime · 2019-10-04T03:22:33Z

retest

elasticmachine · 2019-10-04T04:34:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 714029b

Bamieh

LGTM. thanks!

mattkime · 2019-10-07T23:54:15Z

retest

elasticmachine · 2019-10-08T01:16:54Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: f553e47

mattkime · 2019-10-08T02:07:38Z

retest

elasticmachine · 2019-10-08T03:28:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5ee00f1

* Remove injectI18n in management

sainthkh force-pushed the management-i18n branch from 014cb29 to 7b27091 Compare September 18, 2019 03:07

sainthkh marked this pull request as ready for review September 18, 2019 03:17

nickpeihl added the Team:AppArch label Sep 21, 2019

sainthkh mentioned this pull request Oct 1, 2019

Management plugin migration plan #47022

Closed

mattkime force-pushed the management-i18n branch from 7b27091 to f1e941e Compare October 3, 2019 16:01

sainthkh force-pushed the management-i18n branch 2 times, most recently from 7b27091 to bc909ac Compare October 3, 2019 21:35

sainthkh and others added 8 commits October 4, 2019 08:33

Prettierize.

e97b96e

Removed injectI18n.

cf39fe7

Fixes. Fixes.

Fixed Field.js and its tests.

1f947bc

Fixed eslint error.

a453be8

Revert "Fixed Field.js and its tests."

a61f529

This reverts commit bc909ac791160c32581097107dad13c184fc77cb.

Fixed simple tests.

9be6d69

Fixed other tests.

b6f0f77

Fixed x-pack snapshot error.

26eadbe

sainthkh force-pushed the management-i18n branch from bc909ac to 26eadbe Compare October 3, 2019 23:34

sainthkh requested a review from a team October 3, 2019 23:34

TableComponent to Table

714029b

mattkime added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.5.0 labels Oct 4, 2019

sainthkh commented Oct 4, 2019

View reviewed changes

mattkime approved these changes Oct 4, 2019

View reviewed changes

Bamieh approved these changes Oct 7, 2019

View reviewed changes

Merge branch 'master' into management-i18n

f553e47

sainthkh added 2 commits October 8, 2019 10:34

Fixed eslint error.

04cefeb

Merge remote-tracking branch 'upstream/master' into management-i18n

5ee00f1

mattkime merged commit 8fd1a36 into elastic:master Oct 8, 2019

mattkime mentioned this pull request Oct 8, 2019

[7.x] Remove injectI18n in management. (#45876) #47552

Merged

mattkime pushed a commit to mattkime/kibana that referenced this pull request Oct 8, 2019

Remove injectI18n in management. (elastic#45876)

276a37f

* Remove injectI18n in management

mattkime added a commit that referenced this pull request Oct 8, 2019

Remove injectI18n in management. (#45876) (#47552)

284cea9

* Remove injectI18n in management

cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Oct 9, 2019

Remove injectI18n in management. (elastic#45876) (elastic#47552)

a2ee402

* Remove injectI18n in management

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove injectI18n in management. #45876

Remove injectI18n in management. #45876

sainthkh commented Sep 17, 2019 •

edited

Loading

elasticmachine commented Sep 17, 2019

elasticmachine commented Sep 17, 2019

elasticmachine commented Sep 21, 2019

mattkime commented Oct 3, 2019

elasticmachine commented Oct 3, 2019

mattkime commented Oct 3, 2019

mattkime commented Oct 3, 2019 •

edited

Loading

sainthkh commented Oct 3, 2019

mattkime commented Oct 4, 2019

sainthkh Oct 4, 2019

elasticmachine commented Oct 4, 2019

mattkime commented Oct 4, 2019

elasticmachine commented Oct 4, 2019

Bamieh left a comment

mattkime commented Oct 7, 2019

elasticmachine commented Oct 8, 2019

mattkime commented Oct 8, 2019

elasticmachine commented Oct 8, 2019

Remove injectI18n in management. #45876

Remove injectI18n in management. #45876

Conversation

sainthkh commented Sep 17, 2019 • edited Loading

Summary

Notes

Checklist

For maintainers

Note

elasticmachine commented Sep 17, 2019

elasticmachine commented Sep 17, 2019

elasticmachine commented Sep 21, 2019

mattkime commented Oct 3, 2019

elasticmachine commented Oct 3, 2019

💔 Build Failed

mattkime commented Oct 3, 2019

mattkime commented Oct 3, 2019 • edited Loading

sainthkh commented Oct 3, 2019

mattkime commented Oct 4, 2019

sainthkh Oct 4, 2019

Choose a reason for hiding this comment

elasticmachine commented Oct 4, 2019

💔 Build Failed

mattkime commented Oct 4, 2019

elasticmachine commented Oct 4, 2019

💚 Build Succeeded

Bamieh left a comment

Choose a reason for hiding this comment

mattkime commented Oct 7, 2019

elasticmachine commented Oct 8, 2019

💔 Build Failed

mattkime commented Oct 8, 2019

elasticmachine commented Oct 8, 2019

💚 Build Succeeded

sainthkh commented Sep 17, 2019 •

edited

Loading

mattkime commented Oct 3, 2019 •

edited

Loading