[ML] Create job tests - Fix model bytes validation #45508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
requested review from
walterra,
darnautov,
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
pheyos
added
the
release_note:skip
💔 Build Failed |
|
retest |
💚 Build Succeeded |
This was referenced Sep 12, 2019
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Sep 12, 2019
This PR adds `model_bytes` to the list of count details that are only validated to be present and re-enables the tests.
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Sep 12, 2019
This PR adds `model_bytes` to the list of count details that are only validated to be present and re-enables the tests.
pheyos
added a commit
that referenced
this pull request
Sep 12, 2019
pheyos
added a commit
that referenced
this pull request
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
model_bytesof a job might change slightly from time to time. The original validations always checked a fixed value, which made a couple test executions fail.This PR adds
model_bytesto the list of count details that are only validated to be present and re-enables the tests.Closes #45447
Closes #45450