Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few issues related to emails in pipeline #45470

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Fix a few issues related to emails in pipeline #45470

merged 2 commits into from
Sep 13, 2019

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Sep 11, 2019 •
edited
Loading

Fixes:

  • E-mail notifications should go to [email protected] instead of me
  • E-mail notification subject has NULL for project_name
  • currentBuild.result is null when build is successful at time of infra e-mail (it's only set to something at the time of an error, or after the entire pipeline has finished), so go ahead and mark it as success

@brianseeders brianseeders added the Feature:CI Continuous integration label Sep 11, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@brianseeders brianseeders reopened this Sep 11, 2019
@brianseeders brianseeders mentioned this pull request Sep 12, 2019
Closed
12 tasks
@spalger
Copy link
Contributor

spalger commented Sep 12, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@spalger spalger added the release_note:skip Skip the PR/issue when compiling release notes label Sep 12, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger
spalger approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianseeders brianseeders merged commit e3a3b7f into elastic:master Sep 13, 2019
@brianseeders brianseeders deleted the fix/pipeline-emails branch September 13, 2019 19:15
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
a17e44d
This was referenced Sep 13, 2019
Closed
Closed
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
4178f1f
@brianseeders brianseeders mentioned this pull request Sep 13, 2019
Closed
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
658a83e
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
80f0546
@brianseeders brianseeders mentioned this pull request Sep 13, 2019
Closed
@brianseeders brianseeders mentioned this pull request Sep 13, 2019
Closed
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
88aa9a1
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
85b3ce0
@brianseeders brianseeders mentioned this pull request Sep 13, 2019
Closed
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
ee6c2c9
@brianseeders brianseeders mentioned this pull request Sep 13, 2019
Merged
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
b45503f
@brianseeders brianseeders mentioned this pull request Sep 13, 2019
Merged
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
9c63dd0
@brianseeders brianseeders mentioned this pull request Sep 13, 2019
Merged
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 13, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (elastic#45470)
3257ee3
@brianseeders brianseeders mentioned this pull request Sep 13, 2019
Merged
brianseeders added a commit that referenced this pull request Sep 16, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (#45470) (#45729)
e7467e5
brianseeders added a commit that referenced this pull request Sep 16, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (#45470) (#45728)
4b84716
brianseeders added a commit that referenced this pull request Sep 16, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (#45470) (#45727)
bbf2d72
brianseeders added a commit that referenced this pull request Sep 16, 2019
@brianseeders
Fix a few issues related to sending emails in pipeline (#45470) (#45726)
4d3e032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team test-pipelines v6.8.4 v7.3.2 v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianseeders @elasticmachine @spalger @jbudz