Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra and Logs UI] Unskip flaky esarchiver source config tests #45397

Conversation

weltenwort
Copy link
Member

This unskips the test that were skipped as a consequence of #42696.

closes #42696

@weltenwort weltenwort added Feature:Metrics UI Metrics UI feature v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 labels Sep 11, 2019
@weltenwort weltenwort self-assigned this Sep 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort
Copy link
Member Author

These failures look unrelated:

grafik

jenkins, test this again

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort
Copy link
Member Author

80 passed runs, 40 to go - jenkins, test this again

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort
Copy link
Member Author

160/160 runs in which the unskipped test suite passed, so I'll assume it's relatively stable. The failures all originate from the maps app tests.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort weltenwort marked this pull request as ready for review September 12, 2019 15:05
@weltenwort weltenwort requested a review from a team September 12, 2019 16:24
@weltenwort
Copy link
Member Author

@elasticmachine update branch

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Kerry350 Kerry350 requested review from Kerry350 and removed request for a team September 16, 2019 11:56
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (Insofar as checking the changes and running these locally).

@weltenwort weltenwort merged commit ed4a6d9 into elastic:master Sep 16, 2019
@weltenwort weltenwort deleted the infra-ui-unskip-flaky-esarchiver-source-config-tests branch September 16, 2019 19:26
weltenwort added a commit to weltenwort/kibana that referenced this pull request Sep 16, 2019
weltenwort added a commit to weltenwort/kibana that referenced this pull request Sep 16, 2019
weltenwort added a commit that referenced this pull request Sep 17, 2019
Backports the following commits to 7.x:
 - [Infra and Logs UI] Unskip flaky esarchiver source config tests (#45397)
weltenwort added a commit that referenced this pull request Sep 17, 2019
Backports the following commits to 7.4:
 - [Infra and Logs UI] Unskip flaky esarchiver source config tests (#45397)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes review Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.4.0 v7.5.0 v8.0.0
Projects
None yet
3 participants