[optimize/bundleContext] do not include absolute urls or windows slashes #45318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations |
jbudz
approved these changes
Sep 11, 2019
💔 Build Failed |
|
@elasticmachine update branch |
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 11, 2019
…tic#45318) * [optimize/bundleContext] do not include absolute urls or windows slashes * simplify the stable clone fn, it doesn't need to be generic
|
7.x/7.5: 3902a46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the optimizer, which is currently embedding absolute paths in the bundle entry files, causing them to always rebuild when run on user machines because the absolute paths change when the install is moved to a different location.
Additionally, the absolute path includes windows slashes when Kibana is built on windows.
Now all strings that are absolute paths will be converted:
absolute:${relative(REPO_ROOT, path)}and have backslashes replaced with forward slashes.