Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[skip ci][Maps] Update search document section with new features" #45301

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Sep 10, 2019

Reverts #44819

Docs tests were failed but the PR was merged anyway.

@spalger spalger requested a review from nreese September 10, 2019 19:57
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0 labels Sep 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes the docs build happy so it makes me happy.

@spalger
Copy link
Contributor Author

spalger commented Sep 10, 2019

Closed backport PRs for source PR, so this no longer needs to be backported.

@spalger spalger deleted the revert-44819-update_search_docs branch September 10, 2019 20:13
@lcawl
Copy link
Contributor

lcawl commented Sep 10, 2019

I think the URL that was needed to fix the issue in the original PR was this:
https://www.elastic.co/guide/en/elasticsearch/reference/master/query-dsl-geo-shape-query.html#_spatial_relations
i.e. Remove extra .html

@gchaps
Copy link
Contributor

gchaps commented Sep 10, 2019

@nik9000 The docs built without errors for both Nathan and I on our local machines. Can we make the doc build work the same in both places?

@nik9000
Copy link
Member

nik9000 commented Sep 10, 2019

@nik9000 The docs built without errors for both Nathan and I on our local machines. Can we make the doc build work the same in both places?

The failure was with inter-doc linking which is very slow to check locally. Mostly because at this point if you run the commands that Jenkins runs you'd end up downloading about 6GB of repos. You totally can do it but I think now that we have the PR test it'd be ok to rely on it to catch the bad links.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 11, 2019
…ation_behaviour

* 'master' of github.com:elastic/kibana: (24 commits)
  [Console] SQL template with triple quote in completion (elastic#45248)
  [ML] Data Frames: Cards as links (elastic#45254)
  fix(code/frontend): should show updating instead of cloning when updating (elastic#45238)
  fix(code/frontend): fix document search result from (elastic#45236)
  disable another flaky suite (elastic#45323) (elastic#45330)
  disable flaky suite (elastic#45105)
  skip flaky suite (elastic#43069)
  skip flaky suite (elastic#45089)
  disable jest suite that has no enabled tests (elastic#44250)
  disable flaky test (elastic#45317)
  disable flaky test (elastic#45315)
  [DOCS] Creates developer folder (elastic#45280)
  [SIEM] Changes ML conditional links to use tabs, fixes a small bug with null filterQuery   (elastic#45218)
  [skip-ci][Maps] Update search docs (elastic#45307)
  Revert "[skip ci][Maps] Update search document section with ne… (elastic#45301)
  Prep visualizations plugin for NP migration. (elastic#44839)
  Replace Discover chart with elastic-charts (elastic#43788)
  [skip ci][Maps] Update search document section with new features (elastic#44819)
  Revert "Revert "[ci] compress jobs for CI stability" (elastic#44584)"
  add src/plugins to the list of plugin dirs to watch (elastic#45033)
  ...

# Conflicts:
#	src/legacy/core_plugins/console/public/src/utils.js
#	src/legacy/core_plugins/console/public/tests/src/utils_string_expanding.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants