Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing bbox from parsed file pending upstream lib fix #45194

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Sep 9, 2019

Resolves #43855. The GeoJSON File Upload feature relies on the lib jsts to clean and validate GeoJSON, however currently there's an issue in the lib when the top-level bbox property is present. We're not currently using any top-level properties on GeoJSON aside from type, geometry, properties and features, so it's safer to just not pass this currently unused bbox property to jsts.

@kindsun kindsun requested a review from nreese September 9, 2019 20:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

LGTM
code review

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kindsun kindsun merged commit 4401bee into elastic:master Sep 9, 2019
kindsun pushed a commit to kindsun/kibana that referenced this pull request Sep 9, 2019
kindsun pushed a commit to kindsun/kibana that referenced this pull request Sep 9, 2019
kindsun pushed a commit to kindsun/kibana that referenced this pull request Sep 10, 2019
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 10, 2019
…-to-np-ready

* 'master' of github.com:elastic/kibana: (138 commits)
  [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943)
  update close/delete system index modals (elastic#45037)
  TS return type of createIndexPatternSelect (elastic#45107)
  [ML] Fix focus chart updating. (elastic#45146)
  [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116)
  [Graph] Re-enable functional test (elastic#44683)
  [SIEM] unique table id for each top talkers table (elastic#45014)
  [SIEM] ip details heading draggable (elastic#45179)
  [Maps][File upload] Set complete on index pattern creation (elastic#44423)
  [Maps] unmount map embeddable component on destroy (elastic#45183)
  [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088)
  fix redirect to maintain search query string (elastic#45184)
  [APM] One-line trace summary (elastic#44842)
  [Infra UI] Display non-metric details on Node Detail page (elastic#43551)
  [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194)
  [Logs UI] Improve live streaming behavior when scrolling (elastic#44923)
  [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970)
  [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851)
  [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077)
  [Reporting] Make screenshot capture less noisy by default (elastic#45185)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants