-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export saved objects based on search criteria #44723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💚 Build Succeeded |
epixa
added
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Sep 4, 2019
Pinging @elastic/kibana-platform |
Thanks! will review tomorrow |
rudolf
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tested on Chrome
💚 Build Succeeded |
This was referenced Sep 6, 2019
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Sep 6, 2019
* export all saved objects returned from search, not all saved objects that exist * remove unused mock
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Sep 6, 2019
* export all saved objects returned from search, not all saved objects that exist * remove unused mock
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 6, 2019
…ete-for-distance_feature * 'master' of github.com:elastic/kibana: [SIEM] Fixes escape bug for filterQuery (elastic#43030) Export saved objects based on search criteria (elastic#44723) refactor(webhook-whitelisting): Removed unneeded schema config (elastic#44974) [APM] Make number of x ticks responsive to the plot width (elastic#44870) [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860)
legrego
added a commit
that referenced
this pull request
Sep 6, 2019
legrego
added a commit
that referenced
this pull request
Sep 6, 2019
legrego
added a commit
that referenced
this pull request
Sep 6, 2019
Sorry for the delayed feedback. There may be an issue with pagination using this method where only the first page would get exported. |
legrego
added a commit
that referenced
this pull request
Sep 9, 2019
legrego
added a commit
that referenced
this pull request
Sep 9, 2019
legrego
added
reverted
release_note:skip
Skip the PR/issue when compiling release notes
and removed
release_note:fix
labels
Sep 9, 2019
legrego
added a commit
that referenced
this pull request
Sep 9, 2019
💚 Build Succeeded |
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚫 Reverted due to issues discovered with paging
👉 Updated PR here: #47223
Summary
Previously, exporting all saved objects from the Saved Objects Management UI did not take the current search criteria into account.
This PR updates the export logic to only export the saved objects that are returned with the current search criteria (optionally including references, of course).
Resolves #27250
Resolves #22590
Resolves #26236