Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.3][skip-ci] Added an inclusion of, "This setting is off by default..." (#42501) #44579

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

GardenPatch
Copy link
Contributor

Backports the following commits to 7.3:

…2501)

* Added an inclusion of, "This setting is off by default..."

* Update docs/management/advanced-options.asciidoc

Co-Authored-By: gchaps <[email protected]>
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cuff-links cuff-links requested a review from gchaps September 2, 2019 01:06
@GardenPatch
Copy link
Contributor Author

Going to reissue these backports as they were attributed to my previous username.

@GardenPatch GardenPatch closed this Sep 5, 2019
@GardenPatch GardenPatch reopened this Sep 6, 2019
@cuff-links cuff-links added release_note:skip Skip the PR/issue when compiling release notes v7.3.0 labels Sep 10, 2019
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cuff-links
Copy link
Contributor

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cuff-links
Copy link
Contributor

@gchaps These test failures are unrelated to our changes. Can we merge?

@cuff-links cuff-links changed the title [7.3] Added an inclusion of, "This setting is off by default..." (#42501) [7.3][skip-ci] Added an inclusion of, "This setting is off by default..." (#42501) Sep 16, 2019
@cuff-links
Copy link
Contributor

@elasticmachine merge upstream

@cuff-links cuff-links merged commit d8fa16c into elastic:7.3 Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants