Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'workpad flash' when loading new workpad #44387

Merged
merged 3 commits into from
Aug 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@

import React from 'react';
import { EuiPage, EuiPageBody, EuiPageContent } from '@elastic/eui';
import { WorkpadManager } from '../../components/workpad_manager';
import { setDocTitle } from '../../lib/doc_title';
import { WorkpadManager } from '../../../components/workpad_manager';
import { setDocTitle } from '../../../lib/doc_title';

export const HomeApp = () => {
export const HomeApp = ({ onLoad = () => {} }) => {
onLoad();
setDocTitle('Canvas');
return (
<EuiPage className="canvasHomeApp" restrictWidth>
Expand Down
20 changes: 20 additions & 0 deletions x-pack/legacy/plugins/canvas/public/apps/home/home_app/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

import { connect } from 'react-redux';
import { resetWorkpad } from '../../../state/actions/workpad';
import { HomeApp as Component } from './home_app';

const mapDispatchToProps = dispatch => ({
onLoad() {
dispatch(resetWorkpad());
},
});

export const HomeApp = connect(
null,
mapDispatchToProps
)(Component);
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const setRefreshInterval = createAction('setRefreshInterval');
export const setWorkpadCSS = createAction('setWorkpadCSS');
export const enableAutoplay = createAction('enableAutoplay');
export const setAutoplayInterval = createAction('setAutoplayInterval');
export const resetWorkpad = createAction('resetWorkpad');

export const initializeWorkpad = createThunk('initializeWorkpad', ({ dispatch }) => {
dispatch(fetchAllRenderables());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
import { isEqual } from 'lodash';
import { getWorkpad, getFullWorkpadPersisted, getWorkpadPersisted } from '../selectors/workpad';
import { getAssetIds } from '../selectors/assets';
import { setWorkpad, setRefreshInterval } from '../actions/workpad';
import { appReady } from '../actions/app';
import { setWorkpad, setRefreshInterval, resetWorkpad } from '../actions/workpad';
import { setAssets, resetAssets } from '../actions/assets';
import * as transientActions from '../actions/transient';
import * as resolvedArgsActions from '../actions/resolved_args';
Expand All @@ -28,6 +29,8 @@ const assetsChanged = (before, after) => {
export const esPersistMiddleware = ({ getState }) => {
// these are the actions we don't want to trigger a persist call
const skippedActions = [
appReady, // there's no need to resave the workpad once we've loaded it.
resetWorkpad, // used for resetting the workpad in state
setWorkpad, // used for loading and creating workpads
setAssets, // used when loading assets
resetAssets, // used when creating new workpads
Expand Down
4 changes: 4 additions & 0 deletions x-pack/legacy/plugins/canvas/public/state/reducers/workpad.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@

import { handleActions } from 'redux-actions';
import { recentlyAccessed } from 'ui/persisted_log';
import { getDefaultWorkpad } from '../defaults';
import {
setWorkpad,
sizeWorkpad,
setColors,
setName,
setWriteable,
setWorkpadCSS,
resetWorkpad,
} from '../actions/workpad';

import { APP_ROUTE_WORKPAD } from '../../../common/lib/constants';
Expand Down Expand Up @@ -44,6 +46,8 @@ export const workpadReducer = handleActions(
[setWorkpadCSS]: (workpadState, { payload }) => {
return { ...workpadState, css: payload };
},

[resetWorkpad]: () => ({ ...getDefaultWorkpad() }),
},
{}
);
2 changes: 1 addition & 1 deletion x-pack/legacy/plugins/canvas/public/style/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
@import 'main';

// Canvas apps
@import '../apps/home/home_app';
@import '../apps/home/home_app/home_app';
@import '../apps/workpad/workpad_app/workpad_app';
@import '../apps/export/export/export_app';

Expand Down