esArchiver: retry kibana config update #43987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
|
retest |
💚 Build Succeeded |
This reverts commit 80e199c.
dmlemeshko
added
release_note:skip
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
retest |
💚 Build Succeeded |
|
@dmlemeshko have we seen this PR resolve the issue? Have you found any logs where the update failed and was retried successfully? Maybe it doesn't fail often enough and we'll just have to try this and see? |
spalger
approved these changes
Aug 27, 2019
I ran ciGroup7 60x times on CI and checked around 20 reports - retry was never called. Since recently we got the same error in other tests (#43776, #42550) I plan to monitor build-stats with retry in master/7.x. |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Aug 27, 2019
* [services/es_archiver] retry uiSettings update * run x-pack-ciGroup7 30x times * Revert "run x-pack-ciGroup7 30x times" This reverts commit 80e199c. * [saved_object_api_integration/common/services] add retry service to the set * add retry service for x-pack api tests
spalger
pushed a commit
that referenced
this pull request
Aug 28, 2019
* [services/es_archiver] retry uiSettings update * run x-pack-ciGroup7 30x times * Revert "run x-pack-ciGroup7 30x times" This reverts commit 80e199c. * [saved_object_api_integration/common/services] add retry service to the set * add retry service for x-pack api tests
|
7.x/7.4: 145945e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This closes #43221, closes #43776, closes #42550
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers