-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] add migration to switch tile layers with EMS_TMS source to vector tile layer #43777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.4.0
labels
Aug 22, 2019
Pinging @elastic/kibana-gis |
💔 Build Failed |
💚 Build Succeeded |
nickpeihl
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Aug 24, 2019
…ctor tile layer (elastic#43777) * [Maps] add migration to switch tile layers with EMS_TMS source to vector tile layers * update migration on sample data saved objects since they have already been migrated * update jest test expect
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
release_note:skip
Skip the PR/issue when compiling release notes
v7.4.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43488
This PR adds a migration script to migrate map saved objects, converting tile layers with EMS_TMS source to vector tile layers
To test,
Import the following saved object before checking out the branch
Open the saved object in the maps application and verify the map is loading
png
tiles by viewing the network tab in the browser dev tools.Stop Kibana, checkout this branch, then restart kibana. Re-open this saved object in the maps app. Verify tiles are now vector tiles (.pbf, Protocolbuffer Binary Format) in network tab