Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Allow index patterns containing commas in recogniser modules #43686

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Aug 21, 2019

When supplying an indexPatternName override to the modules/setup endpoint, it can now contain a comma separated list of indices. These will be split and added as an array to the datafeed's indices.

Example usage:

POST <kibana server>/api/ml/modules/setup/siem_auditbeat_ecs
{
  "indexPatternName": "index1, index2"
}

Also fixes an issue where only indexes was checked for when reading the datafeed json configs.
All modules currently in ML use indexes, probably due to copying and pasting modules when creating new ones.
Now either indices or indexes can be used in a module's datafeed configs.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic marked this pull request as ready for review August 21, 2019 16:23
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 21, 2019 16:23
@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience release_note:fix and removed release_note:enhancement labels Aug 21, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@jgowdyelastic jgowdyelastic merged commit 1f09812 into elastic:master Aug 22, 2019
@jgowdyelastic jgowdyelastic deleted the allow-index-patterns-containing-commas-in-recogniser-modules branch August 22, 2019 07:14
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 22, 2019
…astic#43686)

* [ML] Allow index patterns containing commas in recogniser modules

* fixing issue where only 'indexes' is the allowed datafeed index list
jgowdyelastic added a commit that referenced this pull request Aug 22, 2019
…3686) (#43739)

* [ML] Allow index patterns containing commas in recogniser modules

* fixing issue where only 'indexes' is the allowed datafeed index list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :ml release_note:fix review v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants