-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Allow index patterns containing commas in recogniser modules #43686
Merged
jgowdyelastic
merged 2 commits into
elastic:master
from
jgowdyelastic:allow-index-patterns-containing-commas-in-recogniser-modules
Aug 22, 2019
Merged
[ML] Allow index patterns containing commas in recogniser modules #43686
jgowdyelastic
merged 2 commits into
elastic:master
from
jgowdyelastic:allow-index-patterns-containing-commas-in-recogniser-modules
Aug 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
requested review from
walterra,
peteharverson and
alvarezmelissa87
August 21, 2019 16:22
Pinging @elastic/ml-ui |
jgowdyelastic
added
bug
Fixes for quality problems that affect the customer experience
release_note:fix
and removed
release_note:enhancement
labels
Aug 21, 2019
💚 Build Succeeded |
walterra
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
7 tasks
alvarezmelissa87
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡️
jgowdyelastic
deleted the
allow-index-patterns-containing-commas-in-recogniser-modules
branch
August 22, 2019 07:14
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Aug 22, 2019
…astic#43686) * [ML] Allow index patterns containing commas in recogniser modules * fixing issue where only 'indexes' is the allowed datafeed index list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When supplying an
indexPatternName
override to themodules/setup
endpoint, it can now contain a comma separated list of indices. These will be split and added as an array to the datafeed's indices.Example usage:
Also fixes an issue where only
indexes
was checked for when reading the datafeed json configs.All modules currently in ML use
indexes
, probably due to copying and pasting modules when creating new ones.Now either
indices
orindexes
can be used in a module's datafeed configs.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers