Add x-pack plugin for new platform server licensing information #43623

eliperelman · 2019-08-20T21:21:59Z

Summary

Add x-pack plugin for new platform server licensing information. This will eventually replace the licensing information consumed via xpack_main.

Server implementation
Server tests

Fixes #18356.
Supersedes #41026.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

Dev Docs

Add x-pack plugin for new platform server licensing information. This will eventually replace the licensing information consumed via xpack_main. Upon setup, this plugin exposes an observable API for inspecting and making checks against the license information.

license$.subscribe(license => {
   console.log(license.uid);
   console.log(license.isActive);
   console.log(license.type);

   const { check } = license.check('my-plugin', LICENSE_TYPE.gold);

   if (check !== LICENSE_STATUS.Valid) {
     disableSomething();
   }
});

elasticmachine · 2019-08-20T21:22:02Z

Pinging @elastic/kibana-platform

elasticmachine · 2019-08-20T22:32:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-21T18:37:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-21T19:27:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-21T19:58:09Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-22T00:04:17Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-23T16:32:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-23T19:02:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

x-pack/plugins/licensing/server/index.ts

x-pack/plugins/licensing/server/types.ts

x-pack/plugins/licensing/server/license_feature.ts

x-pack/plugins/licensing/server/licensing.test.ts

x-pack/plugins/licensing/server/licensing_plugin_setup.ts

x-pack/plugins/licensing/server/licensing_plugin.ts

elasticmachine · 2019-08-26T18:41:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-26T19:34:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-26T20:18:39Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-26T22:17:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

joshdover · 2019-08-26T22:55:41Z

Ack: will re-review tomorrow morning

x-pack/plugins/licensing/server/plugin.ts

x-pack/plugins/licensing/server/plugin.test.ts

elasticmachine · 2019-08-29T20:23:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

spalger · 2019-09-02T06:25:41Z

@eliperelman One of the tests from this PR which hasn't been backported yet is flaky, and has been skipped in master, please don't backport the flaky test without the skip, or fix the flaky test before backporting.

#44560

eliperelman · 2019-09-03T18:11:30Z

@restrry forgot to post here, I will be addressing all of your review comments in my next PR as several of your suggestions have already been written in my follow up. Thanks! 👍

…tic#43623) * Add x-pack plugin for new platform server licensing information * Update x-pack translations * Implement core plugin interface for licensing plugin: * Rename references to service to plugin * Use CoreStart in licensing start method * Fix outstanding reference error * Fix type check errors * Address outstanding review comments * Fix type error in tests * Address review comments, move polling logic to standalone * Split up test files * Fix bad reference in test * Use relative reference to poller util * Add more plugin tests to address review comments * Fix different manners of config generation in licensing plugin * Update test fixtures * Fix path to test fixtures

…) (#46920) * Add x-pack plugin for new platform server licensing information * Update x-pack translations * Implement core plugin interface for licensing plugin: * Rename references to service to plugin * Use CoreStart in licensing start method * Fix outstanding reference error * Fix type check errors * Address outstanding review comments * Fix type error in tests * Address review comments, move polling logic to standalone * Split up test files * Fix bad reference in test * Use relative reference to poller util * Add more plugin tests to address review comments * Fix different manners of config generation in licensing plugin * Update test fixtures * Fix path to test fixtures

eliperelman added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 v7.4.0 labels Aug 20, 2019

eliperelman requested a review from a team August 20, 2019 21:21

eliperelman self-assigned this Aug 20, 2019

eliperelman force-pushed the licensing-plugin-x-pack branch from 92d592f to 6c283a4 Compare August 21, 2019 18:14

eliperelman force-pushed the licensing-plugin-x-pack branch from 53a5f82 to 3047690 Compare August 23, 2019 15:15

joshdover suggested changes Aug 23, 2019

View reviewed changes

eliperelman force-pushed the licensing-plugin-x-pack branch from 4140da9 to 63a9d95 Compare August 26, 2019 17:00

eliperelman requested a review from a team August 26, 2019 17:01

eliperelman force-pushed the licensing-plugin-x-pack branch from 5afa576 to d6b878b Compare August 26, 2019 19:30

eliperelman requested a review from joshdover August 26, 2019 22:29

joshdover suggested changes Aug 27, 2019

View reviewed changes

x-pack/plugins/licensing/server/plugin.ts Show resolved Hide resolved

x-pack/plugins/licensing/server/plugin.ts Outdated Show resolved Hide resolved

x-pack/plugins/licensing/server/plugin.test.ts Show resolved Hide resolved

jinmu03 requested a review from epixa August 27, 2019 17:53

eliperelman added 15 commits August 29, 2019 13:42

Implement core plugin interface for licensing plugin:

1cd5c4d

Rename references to service to plugin

ab886c5

Use CoreStart in licensing start method

d600d19

Fix outstanding reference error

4f12da3

Fix type check errors

ae28ac0

Address outstanding review comments

4ebbc71

Fix type error in tests

8a81e3b

Address review comments, move polling logic to standalone

93e3c5a

Split up test files

2252878

Fix bad reference in test

0cda8f4

Use relative reference to poller util

88ab91e

Add more plugin tests to address review comments

d3fe407

Fix different manners of config generation in licensing plugin

6e23ad7

Update test fixtures

cbd182f

Fix path to test fixtures

317a854

eliperelman force-pushed the licensing-plugin-x-pack branch from 4ae4b26 to 317a854 Compare August 29, 2019 18:42

eliperelman merged commit 4667c46 into elastic:master Aug 29, 2019

spalger mentioned this pull request Sep 2, 2019

Failing test: Jest Tests.src/core/utils - Poller executes a function on an interval #44560

Closed

mshustov mentioned this pull request Sep 9, 2019

Add x-pack plugin for new platform browser licensing information #44922

Closed

7 tasks

mshustov added v7.5.0 and removed v7.4.0 labels Oct 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add x-pack plugin for new platform server licensing information #43623

Add x-pack plugin for new platform server licensing information #43623

eliperelman commented Aug 20, 2019 •

edited

Loading

elasticmachine commented Aug 20, 2019

elasticmachine commented Aug 20, 2019

elasticmachine commented Aug 21, 2019

elasticmachine commented Aug 21, 2019

elasticmachine commented Aug 21, 2019

elasticmachine commented Aug 22, 2019

elasticmachine commented Aug 23, 2019

elasticmachine commented Aug 23, 2019

elasticmachine commented Aug 26, 2019

elasticmachine commented Aug 26, 2019

elasticmachine commented Aug 26, 2019

elasticmachine commented Aug 26, 2019

joshdover commented Aug 26, 2019

elasticmachine commented Aug 29, 2019

spalger commented Sep 2, 2019 •

edited

Loading

eliperelman commented Sep 3, 2019

Add x-pack plugin for new platform server licensing information #43623

Add x-pack plugin for new platform server licensing information #43623

Conversation

eliperelman commented Aug 20, 2019 • edited Loading

Summary

Checklist

For maintainers

Dev Docs

elasticmachine commented Aug 20, 2019

elasticmachine commented Aug 20, 2019

💔 Build Failed

elasticmachine commented Aug 21, 2019

💚 Build Succeeded

elasticmachine commented Aug 21, 2019

💔 Build Failed

elasticmachine commented Aug 21, 2019

💔 Build Failed

elasticmachine commented Aug 22, 2019

💚 Build Succeeded

elasticmachine commented Aug 23, 2019

💔 Build Failed

elasticmachine commented Aug 23, 2019

💚 Build Succeeded

elasticmachine commented Aug 26, 2019

💔 Build Failed

elasticmachine commented Aug 26, 2019

💔 Build Failed

elasticmachine commented Aug 26, 2019

💔 Build Failed

elasticmachine commented Aug 26, 2019

💚 Build Succeeded

joshdover commented Aug 26, 2019

elasticmachine commented Aug 29, 2019

💚 Build Succeeded

spalger commented Sep 2, 2019 • edited Loading

eliperelman commented Sep 3, 2019

eliperelman commented Aug 20, 2019 •

edited

Loading

spalger commented Sep 2, 2019 •

edited

Loading