Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent positioning of Timepicker in SearchBar #43255

Merged

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Aug 14, 2019

Summary

Align SearchBar \ Time picker to the right
Resolves #41900

In apps where SearchBar only contains Timepicker, it looks like this:

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom requested a review from a team as a code owner August 14, 2019 10:20
@lizozom lizozom self-assigned this Aug 14, 2019
@lizozom lizozom requested a review from AlonaNadler August 14, 2019 10:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lizozom lizozom changed the title Align SearchBar \ Time picker to the right resolves #41900 Consistent positioning of Timepicker in SearchBar Aug 14, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cchaos
cchaos previously requested changes Aug 14, 2019
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's actually no need to add a custom style for this. The .kbnQueryBar is an EuiFlexGroup component which accepts justifyContent="flexEnd".

@AlonaNadler
Copy link

I checked and played with the PR LGTM, thanks @lizozom

@lizozom
Copy link
Contributor Author

lizozom commented Aug 15, 2019

@cchaos done

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom added the review label Aug 15, 2019
@lizozom lizozom requested review from cchaos and a team August 15, 2019 15:42
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed the change requested by Caroline (who is out) and it looks good.

@lizozom lizozom dismissed cchaos’s stale review August 15, 2019 15:43

Fixed and reviewed by @ryan

@lizozom lizozom merged commit 50371b3 into elastic:master Aug 15, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Aug 15, 2019
lizozom pushed a commit that referenced this pull request Aug 15, 2019
@lizozom lizozom deleted the newplatform/kbn-top-nav/align-timepicker branch November 14, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DISCUSS] Top Nav \ Search Bar behavior consistency
5 participants