[Reporting] Promote many debug log events to info
#43241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
review
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-stack-services |
tsullivan
commented
Aug 14, 2019
💔 Build Failed |
💚 Build Succeeded |
|
ready for review |
tsullivan
commented
Aug 15, 2019
| const userDataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'chromium-')); | ||
| const chromiumArgs = args({ | ||
| userDataDir, | ||
| viewport, | ||
| verboseLogging: this.callerLogger.isVerbose, | ||
| verboseLogging: this.logger.isVerbose, |
There was a problem hiding this comment.
verboseLogging should just be removed: it is not a valid chromium arg.
I think I want to NOT do that in this PR
Bamieh
approved these changes
Aug 15, 2019
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Aug 15, 2019
* [Reporting] Move some log lines out of screenshots/index.ts * promote some getScreenshots logs from debug to info * promote some queue lifecycle event logs from debug to info * Comments and renaming * more info logging: csv from saved search * rollback code changes to be done in future PR * log success above error handling
tsullivan
added a commit
that referenced
this pull request
Aug 16, 2019
* [Reporting] Move some log lines out of screenshots/index.ts * promote some getScreenshots logs from debug to info * promote some queue lifecycle event logs from debug to info * Comments and renaming * more info logging: csv from saved search * rollback code changes to be done in future PR * log success above error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will give users easier insight on events happening on the server during the Reporting lifecycle of creating and generating reports.
There are also a few side-effect changes of moving debug-level logs to be in-context to the helper functions, while remaining as debug level.
Release note: Promoted the logging level for many server-side Reporting events that are internal to job creation and execution. Previously, the logging level was "debug" and is now "info", which makes information about these events visible by default.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers