[ML] Data frame analytics: Hook unit tests. #43199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
v8.0.0
release_note:skip
walterra
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Aug 14, 2019
- moves use_create_analytics_form.ts inside a use_create_analytics_form directory to be able to split up the large file - moves code related to the plain reducer function from ``use_create_analytics_form.tsto its own filereducer.ts` - adds unit tests for use_create_analytics_form.ts and reducer.ts. - Changes the button and modal header text from 'Create data frame analytics job' to 'Create outlier detection job'.
walterra
added a commit
that referenced
this pull request
Aug 14, 2019
- moves use_create_analytics_form.ts inside a use_create_analytics_form directory to be able to split up the large file - moves code related to the plain reducer function from ``use_create_analytics_form.tsto its own filereducer.ts` - adds unit tests for use_create_analytics_form.ts and reducer.ts. - Changes the button and modal header text from 'Create data frame analytics job' to 'Create outlier detection job'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #43102.
use_create_analytics_form.tsinside ause_create_analytics_formdirectory to be able to split up the large filereducerfunction from ``use_create_analytics_form.tsto its own filereducer.ts`use_create_analytics_form.tsandreducer.ts.'Create data frame analytics job'to'Create outlier detection job'.Checklist
For maintainers