Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis Default Editor] Field unit tests #43186

Merged
merged 3 commits into from
Aug 16, 2019
Merged

[Vis Default Editor] Field unit tests #43186

merged 3 commits into from
Aug 16, 2019

Conversation

maryia-lapata
Copy link
Contributor

Summary

This PR contains unit tests for Field control.
Part of #30922.

Coverage

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@maryia-lapata maryia-lapata added release_note:skip Skip the PR/issue when compiling release notes test-unit Feature:Vis Editor Visualization editor issues Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v8.0.0 labels Aug 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

wylieconlon
wylieconlon approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM

flash1293
flash1293 approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, left a bunch of nit-picky comments, also fine merging without addressing those.

src/legacy/ui/public/agg_types/controls/field.test.tsx Show resolved Hide resolved
src/legacy/ui/public/agg_types/controls/field.test.tsx Outdated Show resolved Hide resolved
src/legacy/ui/public/agg_types/controls/field.test.tsx Outdated Show resolved Hide resolved
sulemanof
sulemanof approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Agree with @flash1293 comments 😜

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata merged commit 22945b5 into elastic:master Aug 16, 2019
@maryia-lapata maryia-lapata deleted the field-control branch August 16, 2019 09:03
@maryia-lapata maryia-lapata mentioned this pull request Aug 16, 2019
Merged
maryia-lapata added a commit to maryia-lapata/kibana that referenced this pull request Aug 16, 2019
@maryia-lapata
[Vis Default Editor] Field unit tests (elastic#43186)
f06a60c 
* Unit tests for Field control

* Update field.test.tsx
maryia-lapata added a commit that referenced this pull request Aug 16, 2019
@maryia-lapata
[Vis Default Editor] Field unit tests (#43186) (#43430)
5e80cba 
* Unit tests for Field control

* Update field.test.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulemanof sulemanof sulemanof approved these changes

@flash1293 flash1293 flash1293 approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

Assignees
No one assigned
Labels
backported Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test-unit v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maryia-lapata @elasticmachine @wylieconlon @flash1293 @sulemanof