Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted old kbn-top-nav directive #43168

Merged
merged 7 commits into from
Aug 19, 2019
Merged

Deleted old kbn-top-nav directive #43168

merged 7 commits into from
Aug 19, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Aug 13, 2019 •
edited
Loading

Summary

This PR is required to close #39981

  • Delete old kbn-top-nav directive
  • Rename the new kbn-top-nav directive that wraps the new React component.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

Deleted old kbn-top-nav directive.
0862e9d 
Can be merged only when monitoring replace their last usage.
@lizozom lizozom self-assigned this Aug 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lizozom lizozom mentioned this pull request Aug 13, 2019
Closed
11 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Remove CSS import
1e2f1a2 
Removed fix to config in monitoring (fix is on elastic#43187)
@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom mentioned this pull request Aug 14, 2019
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom marked this pull request as ready for review August 17, 2019 12:37
@lizozom lizozom requested a review from a team as a code owner August 17, 2019 12:37
@lizozom
Copy link
Contributor Author

lizozom commented Aug 17, 2019

retest

@lizozom lizozom requested review from a team and lukeelmers August 17, 2019 12:37
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

snide
snide approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked over the sass. Mostly deletes 👍

Liza K added 2 commits August 19, 2019 12:07
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ppisljar
ppisljar approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@lizozom lizozom merged commit c05598f into elastic:master Aug 19, 2019
@lizozom lizozom mentioned this pull request Aug 19, 2019
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Aug 19, 2019
Deleted old kbn-top-nav directive (elastic#43168)
db03ff1 
* Deleted old kbn-top-nav directive.
Can be merged only when monitoring replace their last usage.

* fix texts

* Remove CSS import
Removed fix to config in monitoring (fix is on elastic#43187)

* rename monitoring directive
lizozom pushed a commit that referenced this pull request Aug 19, 2019
Deleted old kbn-top-nav directive (#43168) (#43523)
4849d03 
* Deleted old kbn-top-nav directive.
Can be merged only when monitoring replace their last usage.

* fix texts

* Remove CSS import
Removed fix to config in monitoring (fix is on #43187)

* rename monitoring directive
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 19, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into chore/console…
98e12c2 
…_update_json_spec

* 'master' of github.com:elastic/kibana: (35 commits)
  fix: 🐛 pass whole action context to isCompatible() method (elastic#43457)
  Deleted old kbn-top-nav directive (elastic#43168)
  [ML] Fixing cloning of single metric distinct count job (elastic#43435)
  Update @elastic/charts version 8.1.6 > 9.1.1 (elastic#43516)
  [Inspector Views] [Request View] - Migrate inspector_views to new platform (elastic#43191)
  [ML] Adding loading indicators to all wizard charts (elastic#43382)
  disable flaky test (elastic#43492)
  feature(code/frontend): cancel file blob and directory commits request if outdated (elastic#43348)
  fix(code/frontend): button group url should have previous query string (elastic#43428)
  [SIEM] Fixes index substring incorrectly matching configured indices and failing to install ML job (elastic#43409)
  [SIEM] Adds performance enhancements such by removing wasted renderers and adding incremental DOM rendering (elastic#43157)
  disable flaky test (elastic#37859)
  Added sass lint to Canvas (elastic#43410)
  [Maps] add indicator when layer is filtered by search bar (elastic#43283)
  Properly validate current user password during password change. (elastic#43447)
  Spaces - allow for hex color codes that include uppercase characters (elastic#43470)
  [Reporting] Add a bit more logging and a few more logging level promotions (elastic#43415)
  Partially convert index pattern server to typescript (elastic#43291)
  [Infra UI] Use sum for aggregating AWS metrics. (elastic#43293)
  [SIEM] Format bytes columns in timeline (elastic#43147)
  ...
@lizozom lizozom deleted the newplatform/kbn-top-nav/rename-directive branch November 14, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@snide snide snide approved these changes

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace kbn_top_nav with a new React component
4 participants
@lizozom @elasticmachine @snide @ppisljar