Restore vega.enableExternalUrls documentation #42820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vega.enableExternalUrls setting missing but it still supported, so needed to be added
💚 Build Succeeded |
gchaps
added
release_note:skip
|
Pinging @elastic/kibana-docs |
nyurik
approved these changes
Aug 8, 2019
gchaps
approved these changes
Aug 8, 2019
timroes
changed the title
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 9, 2019
vega.enableExternalUrls setting missing but it still supported, so needed to be added
|
I'll take care of backporting, Lara. |
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 9, 2019
vega.enableExternalUrls setting missing but it still supported, so needed to be added
timroes
pushed a commit
that referenced
this pull request
Aug 9, 2019
timroes
pushed a commit
that referenced
this pull request
Aug 9, 2019
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 9, 2019
vega.enableExternalUrls setting missing but it still supported, so needed to be added
timroes
pushed a commit
that referenced
this pull request
Aug 9, 2019
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 9, 2019
vega.enableExternalUrls setting missing but it still supported, so needed to be added
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 9, 2019
vega.enableExternalUrls setting missing but it still supported, so needed to be added
timroes
pushed a commit
that referenced
this pull request
Aug 9, 2019
timroes
pushed a commit
that referenced
this pull request
Aug 9, 2019
|
Thanks @timroes !! I was trying to do it myself using the backport with no success! So, I really appreciate that you take care of it! |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vega.enableExternalUrls setting was removed in the docs for all 7.x versions.
After having double checked with Kibana team that such setting is actually supported, I could conclude that it was missing in the documentation.
So I have added the setting explanation in the documentation.