-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose createRouter from HttpService, prepare handlers for context introduction #42686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
mshustov
added
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
Feature:New Platform
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
labels
Aug 8, 2019
Pinging @elastic/kibana-platform |
💚 Build Succeeded |
joshdover
reviewed
Aug 8, 2019
createRouter registers a router under the hood. that reduces API surface for consumers
💚 Build Succeeded |
kobelb
approved these changes
Aug 9, 2019
joshdover
approved these changes
Aug 9, 2019
💚 Build Succeeded |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Aug 10, 2019
…troduction (elastic#42686) * expose createRouter, prepare route handler for context introduction. * fix tests * update examples in docs * update tests * re-genereated docs * remove registerRouter from http service contract createRouter registers a router under the hood. that reduces API surface for consumers * address comments * update docs
mshustov
added a commit
that referenced
this pull request
Aug 10, 2019
…troduction (#42686) (#43072) * expose createRouter, prepare route handler for context introduction. * fix tests * update examples in docs * update tests * re-genereated docs * remove registerRouter from http service contract createRouter registers a router under the hood. that reduces API surface for consumers * address comments * update docs
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 12, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (22 commits) [Code]: downgrade the log level of error message from subprocess (elastic#42925) [Code] Cancel clone/update job in the middle if disk space over the watermark (elastic#42890) Add Kibana App specific URL to the help menu (elastic#34739) (elastic#42580) [Maps] refactor createShapeFilterWithMeta to support more than just polygons (elastic#43042) Skip flaky es_ui_shared/request tests. Pass uiSettings to all data plugin services (elastic#42159) [SIEM] Upgrades react-redux and utilize React.memo for performance gains (elastic#43029) [skip-ci][Maps] add maki icon sheet to docs (elastic#43063) Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (elastic#41305) Update dependency commander to v3 (elastic#43041) Update dependency @percy/agent to ^0.10.0 (elastic#40517) [Maps] only show top hits checkbox if index has date fields (elastic#43056) run chained_controls on Firefox to catch regression (elastic#43044) fixing issue with dashboard csv download (elastic#42964) Expose task manager as plugin instead of server argument (elastic#42966) Expose createRouter from HttpService, prepare handlers for context introduction (elastic#42686) [Code] disk watermark supports percentage and absolute modes (elastic#42987) [apps/dashboard] skip part of filtering tests on FF (elastic#43047) [ML] Kibana management jobs list (elastic#42570) [ML] Fix check for watcher being enabled (elastic#43025) ...
mshustov
added
release_note:skip
Skip the PR/issue when compiling release notes
and removed
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
labels
Aug 14, 2019
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported
Feature:New Platform
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added createRouter as a part of HttpService Setup contract.
It serves 2 purposes:
Dev docs are covered by #41894
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers