Address feedback on new IndexPatterns implementation. #42646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
Feature:Data Views
|
Pinging @elastic/kibana-app-arch |
lukeelmers
changed the title
refresh param in IndexPatterns get methods optional.
💔 Build Failed |
walterra
approved these changes
Aug 6, 2019
mattkime
approved these changes
Aug 6, 2019
…tterns-getTitle # Conflicts: # src/legacy/ui/public/index_patterns/index_patterns.ts
💚 Build Succeeded |
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Aug 7, 2019
lukeelmers
added a commit
that referenced
this pull request
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42511
Dev Docs
In #39247, changes were introduced that added a required
refreshparameter on the followingIndexPatternsmethods:getIdsgetTitlesgetFieldsWhile the code technically still worked without a param because
undefinedis falsey, it makes it less convenient to use from TS files.Based on the feedback in #42511, this PR updates the service so that each of these params is optional, with a default of
false.This also replaces usages of lodash
getin theIndexPatternsclass with the more TS-friendlyidx.