Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched graph to use new top nav #42602

Closed

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Aug 5, 2019

Summary

Switched Graph to use new top nav directive, as part of #39981

Dev Docs \ QA

Graph used kbnTopNav.currentKey to indicate and store the active UI component (even if it's not inside the top nav at all). While deprecating this behavior, I had changed the implementation behind the following buttons:

Should open the field choice view:
image

Should toggle the field config views:
image

Should collapse previously opened top menus:
image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom self-assigned this Aug 5, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants