[Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction #42582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest |
💚 Build Succeeded |
|
Pinging @elastic/kibana-app-arch |
alexwizp
added
v7.4.0
v8.0.0
Feature:Vega
lukeelmers
requested changes
Aug 5, 2019
src/legacy/core_plugins/vis_type_vega/public/vega_request_handler.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
lizozom
approved these changes
Aug 7, 2019
src/legacy/core_plugins/vis_type_vega/public/vega_request_handler.ts
Outdated
Show resolved
Hide resolved
| export const createVegaFn = (dependencies) => ({ | ||
| name: 'vega', | ||
| const name = 'vega'; | ||
| type Context = KibanaContext | null; |
There was a problem hiding this comment.
@lukeelmers talked to @alexwizp
Were unclear about the meaning of the Context type, in the scope of ExpressionFunction?
There was a problem hiding this comment.
@lizozom @alexwizp Context is the output of one function that gets passed to the next. For example, in this expression:
esaggs aggConfig="blah blah" | vega spec="hi"
The value returned by the esaggs function and piped into the vega function is called "Context".
Each expression function defines which context types it accepts as context...
kibana/src/legacy/core_plugins/vis_type_vega/public/vega_fn.ts
Lines 49 to 51 in f9aca22
...And which context type it returns (Return interface) as type:
💚 Build Succeeded |
💚 Build Succeeded |
lukeelmers
approved these changes
Aug 8, 2019
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Aug 9, 2019
…unction (elastic#42582) * [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction * fix PR comments * fix PR comments
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 9, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (306 commits) [ML] Adding job overrides to the module setup endpoint (elastic#42946) [APM] Fix missing RUM url (elastic#42940) close socket timeouts without message (elastic#42456) Upgrade elastic/charts to 8.1.6 (elastic#42518) [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962) Add custom formatting for Date Nanos Format (elastic#42445) [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582) add socket.getPeerCertificate to KibanaRequest (elastic#42929) [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683) [ML] Data frames: Updated stats structure. (elastic#42923) [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841) [kbn-es] Support for passing regex value to ES (elastic#42651) Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840) Add Elasticsearch SSL support for integration tests (elastic#41765) Fix duplicate fetch in Visualize (elastic#41204) [DOCS] TSVB and Timelion clean up (elastic#42953) [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623) [APM] Use rounded bucket sizes for transaction distribution (elastic#42830) [yarn.lock] consistent resolve domain (elastic#42969) [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #38247
What was done in this PR:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers