[7.x] Initial conversion of Index Patterns service to TypeScript. (#39247) #42288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This was referenced Jul 31, 2019
lukeelmers
force-pushed
the
backport/7.x/pr-39247
branch
from
5c099d6 to
0aab153
Compare
This comment has been minimized.
This comment has been minimized.
|
retest |
💚 Build Succeeded |
4 tasks
lukeelmers
force-pushed
the
backport/7.x/pr-39247
branch
from
afdb11a to
40f6fa7
Compare
💚 Build Succeeded |
lukasolson
requested changes
Aug 2, 2019
There was a problem hiding this comment.
Was just playing around with this and it looks like something changed so that this line doesn't fire in the Angular world correctly: https://github.com/elastic/kibana/pull/35262/files#diff-e01c180041e1a85b1baec38ca1446211R208
I think we need to wrap it in a $scope.$evalAsync since something along the way is no longer triggering the Angular digest cycle.
I've got some instructions here to set up a time-based interval pattern from a regular one if that's helpful.
lukeelmers
force-pushed
the
backport/7.x/pr-39247
branch
from
40f6fa7 to
c9d1b34
Compare
lukasolson
approved these changes
Aug 2, 2019
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: